Skip to content

Add missing unlock#1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MauroToscano merged 2 commits into from
Nov 20, 2024
Merged

Add missing unlock #1450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856581b
fix_lock
MauroToscano Nov 20, 2024
240fd8a
Fix double unlock
MauroToscano Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions aggregator/pkg/server.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,9 +99,6 @@ func (agg *Aggregator) ProcessOperatorSignedTaskResponseV2(signedTaskResponse *t
*reply = 0
}

agg.AggregatorConfig.BaseConfig.Logger.Info("- Unlocked Resources: Task response processing finished")
agg.taskMutex.Unlock()

return nil
}

Expand DownExpand Up@@ -143,11 +140,9 @@ func (agg *Aggregator) ProcessNewSignature(ctx context.Context, taskIndex uint32
func (agg *Aggregator) GetTaskIndex(batchIdentifierHash [32]byte) (uint32, error) {
getTaskIndex_func := func() (uint32, error) {
agg.taskMutex.Lock()
agg.AggregatorConfig.BaseConfig.Logger.Info("- Locked Resources: Starting processing of Response")
taskIndex, ok := agg.batchesIdxByIdentifierHash[batchIdentifierHash]
agg.taskMutex.Unlock()
if !ok {
agg.taskMutex.Unlock()
agg.logger.Info("- Unlocked Resources: Task not found in the internal map")
return taskIndex, fmt.Errorf("Task not found in the internal map")
} else {
return taskIndex, nil
Expand Down