Uh oh!
There was an error while loading. Please reload this page.
docs: pause process with multisig - #1482
Merged
Merged
Conversation
JuArce
marked this pull request as ready for review
November 25, 2024 19:02
PatStiles
commented
Nov 26, 2024
Contributor
We should add a section on verifying via cast or another tool that the contract is |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Marcos Nicolau <76252340+MarcosNicolau@users.noreply.github.com>
MarcosNicolau
approved these changes
Nov 26, 2024
Comment on lines
+60
to
+62
| ``` | ||
| make get_paused_state_batcher_payments_service | ||
| ``` |
Contributor
There was a problem hiding this comment.
Get the following error when running this:
/bin/bash: contracts/scripts/get_paused_state_batcher_payments_service.sh: No such file or directoryUh oh!
There was an error while loading. Please reload this page.
PatStiles
approved these changes
Nov 27, 2024
uri-99
suggested changes
Nov 27, 2024
uri-99
left a comment
Contributor
There was a problem hiding this comment.
req changes until i do some fixes
uri-99
reviewed
Nov 27, 2024
Uh oh!
There was an error while loading. Please reload this page.
| 2. Go to the `Transactions` tab and find the transaction that was proposed. | ||
| 3. Get the ```pauseAll()``` signature by running: |
Contributor
There was a problem hiding this comment.
Suggested change
| 3. Get the ```pauseAll()``` signature by running: | |
| 3. Get the ```pauseAll()``` signature by running in your terminal: |
| To propose the pause transaction you can follow the steps below: | ||
| 1. Go to [Safe](https://app.safe.global/home) |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. Go to [Safe](https://app.safe.global/home) | |
| 1. Go to [Safe](https://app.safe.global/home) and connect your wallet. |
uri-99
approved these changes
Nov 27, 2024
avilagaston9
approved these changes
Nov 27, 2024
avilagaston9
left a comment
Contributor
There was a problem hiding this comment.
Works in my machine. Left some minor comments
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
uri-99
reviewed
Nov 27, 2024
Comment on lines
+45
to
+47
| 1. Propose the transaction with the multisig following the [Propose Unpause Guide](./4_b_3_propose_unpause.md). | ||
| 2. After the unpause is proposed, multisig participants can approve the unpause following the [Approve Unpause Guide](./4_b_4_approve_unpause.md). |
uri-99
enabled auto-merge
November 27, 2024 18:19
avilagaston9 pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Klaus @ LambdaClass <18153834+klaus993@users.noreply.github.com> Co-authored-by: Marcos Nicolau <76252340+MarcosNicolau@users.noreply.github.com> Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pause process with multisig wallet
Description
This PR adds docs for the pause process using a multisig for the AlignedLayerServiceManager or the BatcherPaymentService
Type of change