Skip to content

Feat(docs): add docs for unpause process with multisig - #1497

Merged
JuArce merged 20 commits into
stagingfrom
1486-add-unpause-process-with-multisig
Dec 9, 2024
Merged

Feat(docs): add docs for unpause process with multisig#1497
JuArce merged 20 commits into
stagingfrom
1486-add-unpause-process-with-multisig

Conversation

@PatStiles

@PatStilesPatStiles commented Nov 27, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Add docs for unpause process with multisig

Description

Closes#1486

  • Add docs for unpause process with multisig
  • Fix an environment variable sourcing issue in deploy_batcher_payment_service

Type of change

Please delete options that are not relevant.

  • New feature

@github-actions

github-actionsBot commented Nov 27, 2024•
edited
Loading

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 75a367e52dd427c85422ad7b12c9b9af565a0838, compared to commit: d57c02803650e34b3e053e136339438549e5d354

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagercreateNewTask
receive		+477 ❌
+560 ❌		+0.63%
+1.20%
Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager5,231,234 (0)createNewTask
receive		75,983 (+19,864)
47,195 (+23,878)		+35.40%
+102.41%		76,275 (+477)
47,195 (+560)		+0.63%
+1.20%		76,211 (+60)
47,195 (0)		+0.08%
0.00%		76,994 (-87)
47,195 (0)		-0.11%
0.00%		256 (0)
256 (0)
RegistryCoordinatorHarness5,862,162 (+125,839)

@uri-99
uri-99 changed the base branch from staging to 1422-docs-add-pause-process-with-multisigNovember 27, 2024 18:12
uri-99
uri-99 reviewed Nov 27, 2024
View reviewed changes
Comment threadcontracts/scripts/deploy_batcher_payment_service.sh
avilagaston9
avilagaston9 approved these changes Nov 27, 2024
View reviewed changes

@avilagaston9avilagaston9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nit comments. Otherwise, LGTM

Comment threaddocs/0_internal/4_b_3_propose_unpause.md Outdated
Comment threaddocs/0_internal/4_b_3_propose_unpause.md
Comment threaddocs/0_internal/4_b_4_approve_unpause.md Outdated
Base automatically changed from 1422-docs-add-pause-process-with-multisig to stagingNovember 27, 2024 18:54
@uri-99
uri-99 added this pull request to the merge queueNov 27, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@JuArce
JuArce enabled auto-merge December 6, 2024 15:24
@JuArce
JuArce added this pull request to the merge queueDec 6, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to no response for status checks Dec 6, 2024
@JuArce
JuArce added this pull request to the merge queueDec 9, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Dec 9, 2024
@JuArce
JuArce added this pull request to the merge queueDec 9, 2024
Merged via the queue into staging with commit eadd8aeDec 9, 2024
@JuArce
JuArce deleted the 1486-add-unpause-process-with-multisig branch December 9, 2024 14:42
@JuArceJuArce mentioned this pull request Sep 9, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArceJuArceJuArce approved these changes
@MarcosNicolauMarcosNicolauMarcosNicolau approved these changes
+2 more reviewers
@uri-99uri-99uri-99 approved these changes
@avilagaston9avilagaston9avilagaston9 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@PatStilesPatStiles

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PatStiles@uri-99@JuArce@avilagaston9@MarcosNicolau@klaus993