Uh oh!
There was an error while loading. Please reload this page.
fix: grafana warnings - #1514
Merged
Merged
Conversation
fix: user_errors warning
MarcosNicolau
approved these changes
Nov 28, 2024
Oppen
approved these changes
Nov 28, 2024
Oppen
commented
Nov 28, 2024
Contributor
New clippy, new broken CI. |
uri-99
approved these changes
Nov 28, 2024
JulianVentura
approved these changes
Nov 28, 2024
JulianVentura
left a comment
Contributor
There was a problem hiding this comment.
Worked fine and no errors were seen
PatStiles
approved these changes
Nov 28, 2024
Uh oh!
There was an error while loading. Please reload this page.
# Conflicts: # grafana/provisioning/dashboards/aligned/aggregator_batcher.json
fix: user_errors warning
samoht9277 pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
avilagaston9 pushed a commit
that referenced
this pull request
Nov 29, 2024
Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove grafana warnings
Merge after #1511
Description
Metrics names are not following conventions, so grafana shows a warning about that
ie: received_proofs -> received_proofs_count
How to Test
Run all the components
make run_metricsGo to grafana dashboard
localhost:3000Grafana should show metrics correctly and should not show warnings
Type of change
Checklist