Uh oh!
There was an error while loading. Please reload this page.
refactor: move createTask simulation before s3 upload - #1567
Merged
JuArce merged 3 commits intoDec 10, 2024
Merged
Conversation
uri-99
reviewed
Dec 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
uri-99
reviewed
Dec 4, 2024
uri-99
left a comment
Contributor
There was a problem hiding this comment.
code looks good, need to test
PatStiles
approved these changes
Dec 5, 2024
JulianVentura
approved these changes
Dec 5, 2024
JulianVentura
left a comment
Contributor
There was a problem hiding this comment.
Code looks fine and worked as expected locally
uri-99
approved these changes
Dec 5, 2024
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 6, 2024
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Dec 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
removed this pull request from the merge queue due to no response for status checks
Dec 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JuArce
deleted the
1524-fixbatcher-createtask-simulation-should-be-executed-before-sending-batch-to-s3
branch
December 10, 2024 14:40
PatStiles pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
PatStiles pushed a commit
that referenced
this pull request
Jan 10, 2025
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the
createNewTasksimulation to run before uploading the batch toS3.Testing
Run a local
devnetand make it revert by:batchMerkleRootBatcherPaymentServicecontract to trigger a revertYou should see that the batch isn't uploaded to
s3when the simulation fails.Type of change
Checklist