Skip to content

Corrected errors in deployment scripts, added multiple fixes from audits to contracts - #1623

Merged
ilitteri merged 28 commits into
testnetfrom
fix-script
Dec 17, 2024
Merged

Corrected errors in deployment scripts, added multiple fixes from audits to contracts#1623
ilitteri merged 28 commits into
testnetfrom
fix-script

Conversation

@jrchatruc

@jrchatrucjrchatruc commented Dec 16, 2024•
edited by MauroToscano
Loading

Copy link
Copy Markdown
Contributor

Corrected errors in deployment scripts, added multiple fixes from audits to contracts

This PR corrects erros in the deployment scripts. Additionally, it addersses the following issues with the contracts:

  • TOTAL_SUPPLY constant is removed since it's redundant
  • Solidity version was outdated
  • Pragma versions where not fixed
  • Missing docstrings were added
  • TokenClaimed event parameters were documented

@jrchatrucjrchatruc changed the title [WIP] Fix proxy admin deployment in scriptFix proxy admin deployment in scriptDec 16, 2024
MegaRedHand
MegaRedHand approved these changes Dec 17, 2024
View reviewed changes
Comment threadclaim_contracts/script/UpgradeToAlignedTokenV3.s.sol
Comment threadclaim_contracts/src/AlignedToken.sol
@ilitteri
ilitteri merged commit c6ef331 into testnetDec 17, 2024
@ilitteri
ilitteri deleted the fix-script branch December 17, 2024 21:11
@ilitteri

ilitteri commented Dec 20, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes OpenZeppelin issues:

  • L-01
  • L-04
  • L-05
  • L-06
  • N-012

@ilitteri

ilitteri commented Dec 20, 2024

Copy link
Copy Markdown
Contributor

Fixes Least Authority Suggestion 2

@MauroToscanoMauroToscano changed the title Fix proxy admin deployment in scriptCorrected errors in deployment scripts, added multiple fixes from audits to contractsDec 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@ilitteriilitteriilitteri approved these changes
@juanbonojuanbonojuanbono approved these changes
@MegaRedHandMegaRedHandMegaRedHand approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jrchatruc@ilitteri@juanbono@MegaRedHand