Skip to content

fix(docs): batcher and explorer urls - #1688

Merged
JuArce merged 9 commits into
testnetfrom
fix-doc-urls
Dec 30, 2024
Merged

fix(docs): batcher and explorer urls#1688
JuArce merged 9 commits into
testnetfrom
fix-doc-urls

Conversation

@avilagaston9

@avilagaston9avilagaston9 commented Dec 30, 2024

Copy link
Copy Markdown
Contributor

Fix Batcher and Explorer urls

Description

  • Adds Explorer url to docs (mainnet and Holesky).
  • Updates batcher url for mainnet.

Type of change

  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9
avilagaston9 marked this pull request as ready for review December 30, 2024 16:19
@avilagaston9avilagaston9 self-assigned this Dec 30, 2024
JuArce
JuArce requested changes Dec 30, 2024
View reviewed changes

@JuArceJuArce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use holesky on the predefined examples. It could lead to users sending funds in mainnet by error

Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
avilagaston9and others added 2 commits December 30, 2024 14:28
@avilagaston9@JuArce
Update docs/3_guides/0_submitting_proofs.md
ec4ce70
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
@avilagaston9
fix: use holesky in the examples
bc1e43f
@avilagaston9

avilagaston9 commented Dec 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Use holesky on the predefined examples. It could lead to users sending funds in mainnet by error
@JuArce

Addressed in bc1e43f!

uri-99
uri-99 suggested changes Dec 30, 2024
View reviewed changes
Comment threaddocs/3_guides/0_submitting_proofs.md Outdated
Comment threaddocs/3_guides/0_submitting_proofs.md
Comment threaddocs/3_guides/1.2_SDK_api_reference.md
Comment threaddocs/3_guides/1.2_SDK_api_reference.md
Comment threaddocs/3_guides/1.2_SDK_api_reference.md
Comment threaddocs/3_guides/1.2_SDK_api_reference.md
Comment threaddocs/3_guides/1.2_SDK_api_reference.md
avilagaston9and others added 6 commits December 30, 2024 14:52
@avilagaston9@uri-99
Update docs/3_guides/0_submitting_proofs.md
d6b4920
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
@avilagaston9@uri-99
Update docs/3_guides/1.2_SDK_api_reference.md
657f11e
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
@avilagaston9@uri-99
Update docs/3_guides/1.2_SDK_api_reference.md
bed5630
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
@avilagaston9@uri-99
Update docs/3_guides/1.2_SDK_api_reference.md
d2a14a9
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
@avilagaston9@uri-99
Update docs/3_guides/1.2_SDK_api_reference.md
869a299
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
@avilagaston9@uri-99
Update docs/3_guides/1.2_SDK_api_reference.md
32a284e
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
@JuArce
JuArce merged commit 1ebb705 into testnetDec 30, 2024
@JuArce
JuArce deleted the fix-doc-urls branch December 30, 2024 18:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArceJuArceJuArce approved these changes
+2 more reviewers
@OppenOppenOppen approved these changes
@uri-99uri-99uri-99 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@avilagaston9avilagaston9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avilagaston9@Oppen@uri-99@JuArce