chore: output BatcherPaymentService addresses as JSON

[MegaRedHand]

Output BatcherPaymentService addresses as JSON

Description

This PR changes the BatcherPaymentService deployment script to follow the convention of outputting the addresses of deployed contracts in a JSON file.

Type of change

Refactor

Checklist

• “Hotfix” to testnet, everything else to staging
• Linked to Github Issue
• This change depends on code or research by an external entity
  • Acknowledgements were updated to give credit
• Unit tests added
• This change requires new documentation.
  • Documentation has been added/updated.
• This change is an Optimization
  • Benchmarks added/run
• Has a known issue
  • Link to the open issue addressing it
• If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
  • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
  • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

[JuArce]

Shouldn't we do the same change as in [contracts/scripts/deploy_batcher_payment_service.sh](https://github.com/yetanotherco/aligned_layer/pull/1698/files#diff-4a582041a459061d1464141cee38003ede0385187a21ad63ffdb01dc84cdf8c5)

Both solutions work, but just for keep consistency

batcher_payment_service_proxy=$(jq -r '.addresses.batcherPaymentService' $BATCHER_PAYMENT_SERVICE_OUTPUT_PATH)
batcher_payment_service_implementation=$(jq -r '.addresses.batcherPaymentServiceImplementation' $BATCHER_PAYMENT_SERVICE_OUTPUT_PATH)

[MegaRedHand]

Yes. I didn't do it just to minimize the amount of changes. I'll add it in a bit

[MegaRedHand]

Done. I also removed some stale comments (0c0bbc8), lmk if that's OK

[uri-99]

@MegaRedHand Are you aware the batcher payment addresses are currently being outputted in alignedlayer_deployment_output.json ?

[MegaRedHand]

I saw the bash script uses jq to add those addresses to alignedlayer_deployment_output.json, but that doesn't work for me (and would fail if the format changes).

An alternative could be to do that from the Solidity script. I can change to that approach if that seems better.

[uri-99]

I saw the bash script uses jq to add those addresses to alignedlayer_deployment_output.json, but that doesn't work for me (and would fail if the format changes).

An alternative could be to do that from the Solidity script. I can change to that approach if that seems better.

If the issue arises from the usage of jq , and it is possible to have the BatcherPayment addresses written in another way, I would try to stick to the existing files structure.

Alternatevly, if we need to have these addresses in another file, we would have to make a big migration since many components read the BatcherPayment addresses from the existing output file.

[MegaRedHand]

If the issue arises from the usage of jq , and it is possible to have the BatcherPayment addresses written in another way, I would try to stick to the existing files structure.

Sure! Just to clarify, the changes in this PR don't touch the part that updates the alignedlayer_deployment_output.json file with the BPS addresses. The only difference is that those addresses are also in batcher_deployment_output.json.

[JuArce]

lgtm

[avilagaston9]

LGTM!