Skip to content

feat(cli): Add private-key to deposit to batcher - #1724

Merged
JuArce merged 4 commits into
stagingfrom
feat/add_private_key_to_deposit_to_batcher
Jan 14, 2025
Merged

feat(cli): Add private-key to deposit to batcher#1724
JuArce merged 4 commits into
stagingfrom
feat/add_private_key_to_deposit_to_batcher

Conversation

@PatStiles

@PatStilesPatStiles commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Add private-key to deposit to batcher

Description

Addresses the second item of #1568.

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

avilagaston9
avilagaston9 approved these changes Jan 9, 2025
View reviewed changes

@avilagaston9avilagaston9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit comment. Otherwise, LGTM!

Comment threadbatcher/aligned/src/main.rs Outdated
uri-99
uri-99 suggested changes Jan 9, 2025
View reviewed changes

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing added to cli docs

@PatStiles
PatStilesforce-pushed the feat/add_private_key_to_deposit_to_batcher branch from 13f1ac7 to 9835802CompareJanuary 9, 2025 21:34
@PatStiles
PatStilesforce-pushed the feat/add_private_key_to_deposit_to_batcher branch from 9835802 to 1c4e019CompareJanuary 9, 2025 21:35
uri-99
uri-99 reviewed Jan 10, 2025
View reviewed changes
Comment threadbatcher/aligned/src/main.rs Outdated
JuArce
JuArce requested changes Jan 13, 2025
View reviewed changes

@JuArceJuArce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is missing # How to test section

Comment threadbatcher/aligned/src/main.rs
@JuArce
JuArce added this pull request to the merge queueJan 13, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Jan 13, 2025
@JuArce
JuArce added this pull request to the merge queueJan 14, 2025
Merged via the queue into staging with commit 3b23587Jan 14, 2025
@JuArce
JuArce deleted the feat/add_private_key_to_deposit_to_batcher branch January 14, 2025 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuArceJuArceJuArce approved these changes
@MarcosNicolauMarcosNicolauMarcosNicolau approved these changes
+3 more reviewers
@uri-99uri-99uri-99 approved these changes
@JulianVenturaJulianVenturaJulianVentura approved these changes
@avilagaston9avilagaston9avilagaston9 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PatStiles@uri-99@JulianVentura@JuArce@avilagaston9@MarcosNicolau