Skip to content

hotfix(explorer): fetch latest version from env instead of github - #1738

Merged
JuArce merged 4 commits into
testnetfrom
explorer-hotfix
Jan 14, 2025
Merged

hotfix(explorer): fetch latest version from env instead of github#1738
JuArce merged 4 commits into
testnetfrom
explorer-hotfix

Conversation

@klaus993

@klaus993klaus993 commented Jan 14, 2025•
edited by MarcosNicolau
Loading

Copy link
Copy Markdown
Collaborator

When GitHub is down this function breaks the site

This has been applied in-place in mainnet.

Testing

Run the explorer locally and verify that the version is shown according to the value you set.

@klaus993
Explorer hotfix
535133e
When GitHub is down this function breaks the site
This has been applied in-place in mainnet
@JuArceJuArce changed the title Explorer hotfixhotfix(explorer): fetch latest version from env instead of githubJan 14, 2025
JuArce
JuArce requested changes Jan 14, 2025
View reviewed changes
Comment threadexplorer/.env.dev Outdated
Comment threadexplorer/.env.example Outdated
Oppen
Oppen approved these changes Jan 14, 2025
View reviewed changes

@OppenOppen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than what @JuArce pointed out.

@JuArce
JuArce merged commit 9a4b37b into testnetJan 14, 2025
@JuArce
JuArce deleted the explorer-hotfix branch January 14, 2025 16:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarcosNicolauMarcosNicolauMarcosNicolau approved these changes
@JuArceJuArceJuArce approved these changes
+1 more reviewer
@OppenOppenOppen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@klaus993@Oppen@JuArce@MarcosNicolau