Skip to content

hotfix(aggregator): nil dereference for invalid signature#1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MauroToscano merged 5 commits into from
Jan 28, 2025
Merged

hotfix(aggregator): nil dereference for invalid signature #1753

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bad5e7b
hotfix(aggregator): catch nil signature
Oppen Jan 17, 2025
c0c1848
fix: downgrade to warning
Oppen Jan 17, 2025
0dada5b
Merge branch 'testnet' into hotfix/aggregator_nil_deref
MauroToscano Jan 20, 2025
8dbb2fe
fix: set reply on error path
Oppen Jan 20, 2025
4760d73
Merge branch 'testnet' into hotfix/aggregator_nil_deref
JuArce Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions aggregator/pkg/server.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ package pkg
import (
"context"
"encoding/hex"
"errors"
"fmt"
"net/http"
"net/rpc"
Expand DownExpand Up@@ -48,6 +49,17 @@ func (agg *Aggregator) ProcessOperatorSignedTaskResponseV2(signedTaskResponse *t
"SenderAddress", "0x"+hex.EncodeToString(signedTaskResponse.SenderAddress[:]),
"BatchIdentifierHash", "0x"+hex.EncodeToString(signedTaskResponse.BatchIdentifierHash[:]),
"operatorId", hex.EncodeToString(signedTaskResponse.OperatorId[:]))

if signedTaskResponse.BlsSignature.G1Point == nil {
agg.logger.Warn("invalid operator response with nil signature",
"BatchMerkleRoot", "0x"+hex.EncodeToString(signedTaskResponse.BatchMerkleRoot[:]),
"SenderAddress", "0x"+hex.EncodeToString(signedTaskResponse.SenderAddress[:]),
"BatchIdentifierHash", "0x"+hex.EncodeToString(signedTaskResponse.BatchIdentifierHash[:]),
"operatorId", hex.EncodeToString(signedTaskResponse.OperatorId[:]))
*reply = 1
return errors.New("invalid response: nil signature")
}

taskIndex := uint32(0)

// The Aggregator may receive the Task Identifier after the operators.
Expand Down