Uh oh!
There was an error while loading. Please reload this page.
refactor: simplify signature timeout logic - #1764
Closed
Oppen wants to merge 2 commits into
Closed
Conversation
`ProcessNewSignature` already takes a context to handle cancellation and timeout. We need just to create the context and pass it off, and it will return an appropriate error if the timeout expires. This saves us from creating a goroutine and handling messages just for that. Also improve a little bit of the error reporting.
14 tasks
uri-99
approved these changes
Jan 22, 2025
JuArce
approved these changes
Jan 22, 2025
JuArce
requested changes
Jan 22, 2025
JuArce
left a comment
Collaborator
There was a problem hiding this comment.
This PR is wrong. Eigen's BLSAgg service only honors the context if it can start servicing the request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessNewSignaturealready takes a context to handle cancellation andtimeout. We need just to create the context and pass it off, and it will
return an appropriate error if the timeout expires.
This saves us from creating a goroutine and handling messages just for
that.
Also improve a little bit of the error reporting.
Type of change
Checklist
testnet, everything else tostagingTesting
Basic testing: start a devnet, show it's able to verify proofs.
Alightly more involved testing: register three operators and leave only one up,
so it doesn't reach quorum, the timeout should kick.