Uh oh!
There was an error while loading. Please reload this page.
feat: aggregation mode - #1840
Merged
Merged
Conversation
MauroToscano
marked this pull request as ready for review
April 3, 2025 16:40
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
MauroToscano
approved these changes
Apr 4, 2025
MauroToscano
approved these changes
Apr 4, 2025
JuArce
reviewed
Apr 7, 2025
| //bytes calldata sp1ProofBytes | ||
| ) external; | ||
| function getAggregatedProof(uint64 proofNumber) |
Collaborator
There was a problem hiding this comment.
Would be nice to add docs for this function
JuArce
reviewed
Apr 7, 2025
| @@ -0,0 +1,40 @@ | |||
| use aligned_sdk::core::types::VerificationData; | |||
Collaborator
There was a problem hiding this comment.
We should add checks to avoid OOM DDoS
JuArce
reviewed
Apr 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
JuArce
approved these changes
Apr 7, 2025
JuArce
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
There is missing guide to run in /docs/.../setup_aligned, but it can be added in a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligned aggregation mode first iteration.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging