Skip to content

perf: aggregation-mode sp1 prover setup - #1862

Merged
MauroToscano merged 1 commit into
stagingfrom
fix/agg-mode-sp1-build
Apr 10, 2025
Merged

perf: aggregation-mode sp1 prover setup#1862
MauroToscano merged 1 commit into
stagingfrom
fix/agg-mode-sp1-build

Conversation

@MarcosNicolau

Copy link
Copy Markdown
Collaborator

Description

Use LazyLock to setup the sp1 prover client. This avoids recreating the prover for every usage which we noticed has a big overhead.

Type of change

  • Optimization

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

this avoids recreating the prover for every usage which has quite the overhead
@MarcosNicolauMarcosNicolau changed the title fix: agg mode sp1 buildfix: aggregation-mode sp1 prover setupApr 9, 2025
@MarcosNicolauMarcosNicolau changed the title fix: aggregation-mode sp1 prover setupperf: aggregation-mode sp1 prover setupApr 9, 2025
@MauroToscano
MauroToscano added this pull request to the merge queueApr 10, 2025
Merged via the queue into staging with commit ca2bc86Apr 10, 2025
@MauroToscano
MauroToscano deleted the fix/agg-mode-sp1-build branch April 10, 2025 21:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcosNicolau@MauroToscano@JuArce