Uh oh!
There was an error while loading. Please reload this page.
feat(batcher): poll for unlock events and remove users with unlocked funds - #2123
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MarcosNicolau
left a comment
There was a problem hiding this comment.
General flow worked alright for me
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…lock time of 12 seconds
refactor: add duration variable to try_batch_lock_with_timeout
Uh oh!
There was an error while loading. Please reload this page.
MarcosNicolau
commented
Sep 18, 2025
Worked correctly for me following #2119 instructions, but the CI is failing for some reason |
JuArce
commented
Sep 18, 2025
Ci is working now |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Feat(batcher): Poll for unlock events and remove users with unlocked funds
Description
This PR fetches
BalanceUnlockedevents fromBatcherPaymentServiceto check if an user has proofs in the queue and has unlocked their funds.In that case, the batcher will remove their proofs until the user locks funds again to avoid a withdrawal and trying to discount balace from a user without funds deposited.
Closes#2122
How to Test
Start anvil
Set
balance_unlock_polling_interval_secondsto60inconfig-files/config-batcher.yaml. So the polling is executed every 1 minuteStart batcher
Deposit funds
You can send multiple proofs (less than 16 :p)
And the user should receive the error
User funds have been unlocked and proofs removed from queue.Other tests cases:
Unlock and lock funds. The batcher should not eject the user proofs
To lock funds again, use
Type of change
Checklist
testnet, everything else tostaging