Skip to content

chore: add multisig support to upgrade ServiceManager - #516

Merged
MauroToscano merged 30 commits into
stagingfrom
515-chore-add-multisig-support-to-upgrade-servicemanager
Nov 6, 2024
Merged

chore: add multisig support to upgrade ServiceManager#516
MauroToscano merged 30 commits into
stagingfrom
515-chore-add-multisig-support-to-upgrade-servicemanager

Conversation

@JuArce

@JuArceJuArce commented Jun 27, 2024

Copy link
Copy Markdown
Collaborator

This PR

  • Slightly modifies the upgrade script to only generate the calldata to send to the multisig wallet
  • Writes a guide on how to upgrade the contracts using the multisig

To test

Note

Steps on how to deploy and upgrade are available here docs/3_guides/setup_holesky.md
Steps on how to use the multisig are available here docs/multisig.md

  • Deploy Aligned contracts con sepolia
    • For this, don't forget to change the contracts/scripts/.env variables:
RPC_URL=<a sepolia one>
EXISTING_DEPLOYMENT_INFO_PATH=./script/output/sepolia/eigenlayer_deployment_output.json
DEPLOY_CONFIG_PATH=./script/deploy/config/sepolia/aligned.sepolia.config.json
OUTPUT_PATH=./script/output/sepolia/alignedlayer_deployment_output.json
MULTISIG=true
  • Test the upgrade works only with the multisig, following the guide

@JuArceJuArce self-assigned this Jun 27, 2024
@JuArceJuArce linked an issue Jun 27, 2024 that may be closed by this pull request
Comment threadREADME_INFRASTRUCTURE.md Outdated
Comment threadcontracts/scripts/upgrade_aligned_contracts.sh Outdated
Comment threadcontracts/scripts/upgrade_aligned_contracts.sh
Comment threadREADME_INFRASTRUCTURE.md Outdated
JuArceand others added 3 commits June 28, 2024 12:16
Co-authored-by: Tatu <65305492+srosati@users.noreply.github.com>
…o-upgrade-servicemanager' into 515-chore-add-multisig-support-to-upgrade-servicemanager
@JuArce
JuArce marked this pull request as ready for review June 28, 2024 15:19
Comment threadcontracts/scripts/upgrade_aligned_contracts.sh
@uri-99uri-99 assigned uri-99 and unassigned taturosatiOct 7, 2024
@github-actions

github-actionsBot commented Oct 7, 2024

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 9de2e892b0b879b86a6e6299a8bd717e5e2d04c8, compared to commit: 192a535aa39bbad8cada32b9460bf59e33081685

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagerbatchesState
receive
+44 ❌
+2,138 ❌
+6.46%
+4.76%

Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager5,335,578 (+564,365)batchesState
createNewTask
disableVerifier
enableVerifier
isVerifierDisabled
receive
setDisabledVerifiers
725 (+44)
56,085 (+2,150)
23,911 (+22)
23,803 (-67)
583 (+44)
23,318 (+2,149)
23,801 (+44)
+6.46%
+3.99%
+0.09%
-0.28%
+8.16%
+10.15%
+0.19%
725 (+44)
76,161 (+2,195)
35,504 (+22)
24,447 (-67)
1,249 (+44)
47,015 (+2,138)
34,808 (+44)
+6.46%
+2.97%
+0.06%
-0.27%
+3.65%
+4.76%
+0.13%
725 (+44)
76,249 (+2,198)
35,504 (+22)
24,447 (-67)
583 (+44)
47,202 (+2,138)
34,808 (+44)
+6.46%
+2.97%
+0.06%
-0.27%
+8.16%
+4.74%
+0.13%
725 (+44)
77,095 (+2,225)
47,097 (+22)
25,092 (-67)
2,583 (+44)
47,202 (+2,138)
45,815 (+44)
+6.46%
+2.97%
+0.05%
-0.27%
+1.73%
+4.74%
+0.10%
256 (0)
256 (0)
2 (0)
2 (0)
3 (0)
256 (0)
2 (0)
StrategyManagerMock1,270,846 (-12)
IndexRegistry1,086,925 (-12)
BLSApkRegistryHarness1,837,601 (-12)

Comment threadcontracts/script/upgrade/AlignedLayerUpgrader.s.sol

@MauroToscanoMauroToscano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add an installation guide for jq in the guide to upgrade the multi sig

Comment threadcontracts/script/deploy/AlignedLayerDeployer.s.sol Outdated

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until i implement multisig for upgrade batcher payments

@uri-99uri-99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all contracts are now upgradeable

Comment threadcontracts/scripts/upgrade_aligned_contracts.sh Outdated
Comment threadcontracts/scripts/upgrade_aligned_contracts.sh

@MarcosNicolauMarcosNicolau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs seem clear to me. I sent a batch with all the upgrading transactions and everything went as expected. I left some comments regarding the upgrade of the batcher payment service the transaction was reverting but it might be a skill issue.

Comment threadcontracts/scripts/upgrade_batcher_payment_service.sh Outdated
Comment threadcontracts/scripts/upgrade_batcher_payment_service.sh
Comment threadcontracts/scripts/upgrade_batcher_payment_service.sh
Comment threaddocs/multisig.md Outdated
@MauroToscano
MauroToscano added this pull request to the merge queueNov 6, 2024
Merged via the queue into staging with commit 913c0baNov 6, 2024
@MauroToscano
MauroToscano deleted the 515-chore-add-multisig-support-to-upgrade-servicemanager branch November 6, 2024 20:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

chore: add multisig support to upgrade ServiceManager

7 participants

@JuArce@Oppen@MauroToscano@uri-99@taturosati@MarcosNicolau@entropidelic