fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer

.github/workflows/lint-contracts.yml

-Original file line number
+Diff line change
@@ -0,0 +1,29 @@
+name: Lint contracts
+on:
+ push:
+ branches: [main]
+ pull_request:
+ branches: ["*"]
+ paths:
+ - "contracts/src/core/*.sol"
+ - ".github/workflows/lint-contracts.yml"
+jobs:
+ lint:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Set up Node.js
+ uses: actions/setup-node@v4
+ with:
+ node-version: "20"
+ - name: Install dependencies
+ run: npm install
+ working-directory: contracts
+ - name: Run Solhint
+ run: npm run lint:sol
+ working-directory: contracts

Makefile

-Original file line number
+Diff line change
@@ Expand Up / @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @@
 	@echo "Upgrading Index Registry Contracts..."
 	. contracts/scripts/anvil/upgrade_index_registry.sh
+lint_contracts:
+	@cd contracts && npm run lint:sol
 anvil_start:
 	@echo "Starting Anvil..."
 	anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
@@ Expand DownExpand Up / @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: @@
 build_aligned_contracts:
 	@cd contracts/src/core && forge build
+show_aligned_error_codes:
+	@echo "\nAlignedLayerServiceManager errors:"
+	@cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors
+	@echo "\nBatcherPaymentService errors:"
+	@cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors
 __BUILD__:
 build_binaries:
 	@echo "Building aggregator..."
@@ Expand Down @@

contracts/.gitignore

Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,3 +15,4 @@ docs/

		data/

		node_modules/

contracts/.solhint.json

-Original file line number
+Diff line change
@@ -0,0 +1,13 @@
+{
+ "extends": "solhint:recommended",
+ "rules": {
+ "func-visibility": [
+ "warn",
+ {
+ "ignoreConstructors": true
+ }
+ ],
+ "no-complex-fallback": "off",
+ "func-name-mixedcase": "off"
+ }
+}

contracts/.solhintignore

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		src/core/ERC20Mock.sol

blocks (function() { function addCopyButtons() { document.querySelectorAll('pre code').forEach(function(codeBlock) { if (codeBlock.parentElement.hasAttribute('data-copy-added')) return; codeBlock.parentElement.setAttribute('data-copy-added', 'true'); var btn = document.createElement('button'); btn.textContent = 'Copy'; btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;'; btn.onmouseover = function() { this.style.opacity = '1'; }; btn.onmouseout = function() { this.style.opacity = '0.7'; }; btn.onclick = function() { navigator.clipboard.writeText(codeBlock.textContent).then(function() { btn.textContent = 'Copied!'; setTimeout(function() { btn.textContent = 'Copy'; }, 1500); }); }; codeBlock.parentElement.style.position = 'relative'; codeBlock.parentElement.appendChild(btn); }); } addCopyButtons(); // Re-run on dynamic content var observer = new MutationObserver(addCopyButtons); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix: solidity coding style by NicolasRampoldi · Pull Request #843 · yetanotherco/aligned_layer · GitHub Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. yetanotherco /aligned_layerPublic Notifications You must be signed in to change notification settings Fork 399 Star 313 Code Issues156 Pull requests23 Discussions Actions Projects Wiki Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Wiki Security and quality Insights fix: solidity coding style#843 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged NicolasRampoldi merged 31 commits into main from 835-fix-solidity-coding-style-guideline-violationsAug 26, 2024 Conversation 10 Commits 31 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Merged fix: solidity coding style #843 Show file tree Hide file tree Changes from all commits Commits Show all changes 31 commits Select commit Hold shift + click to select a range 17bd36f ci: add solhint to ci NicolasRampoldi Aug 22, 2024210af8c fix: linter warnings NicolasRampoldi Aug 22, 20248c29f5b fix: newline NicolasRampoldi Aug 22, 20246ec87ba fix: modifier before functions NicolasRampoldi Aug 22, 202454026f3 refactor: change requires for revert with custom errors NicolasRampoldi Aug 22, 20247d79014 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 22, 2024a49ed0f fix: merge conflicts NicolasRampoldi Aug 22, 2024332b080 feat: add lint to makefile NicolasRampoldi Aug 22, 2024d780e6d Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 20240677327 chore: merge conflicts NicolasRampoldi Aug 23, 20243bb64cd refactor: move events and errors to interface NicolasRampoldi Aug 23, 2024c9b32e9 refactor: if else statement NicolasRampoldi Aug 23, 2024a0fdcd2 refactor: change user_data to senderData NicolasRampoldi Aug 23, 20240191794 refactor: change user_data to signerData NicolasRampoldi Aug 23, 2024ca7c797 fix: linter NicolasRampoldi Aug 23, 2024e5614be fix: linter NicolasRampoldi Aug 23, 20240d69dbb chore: anvil state NicolasRampoldi Aug 23, 20248550d23 chore: anvil state NicolasRampoldi Aug 23, 2024bfdf79b Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 202451bc162 chore: anvil state NicolasRampoldi Aug 23, 20249190dc1 ci: add max-warnings 0 NicolasRampoldi Aug 23, 20244f9d4a0 ci: test ci to fail NicolasRampoldi Aug 23, 20241cb2866 fix: linter NicolasRampoldi Aug 23, 2024f1829b2 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 23, 2024f830819 chore: anvil state NicolasRampoldi Aug 23, 2024b4f256c Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024c5e8d30 chore: anvil state NicolasRampoldi Aug 26, 2024a20bc09 feat: add make show_aligned_error_codes uri-99 Aug 26, 202428feaa8 feat: add error codes in errors, directly on the contracts uri-99 Aug 26, 20244392f54 Merge branch 'main' into 835-fix-solidity-coding-style-guideline-viol… NicolasRampoldi Aug 26, 2024f537707 chore: merge conflicts NicolasRampoldi Aug 26, 2024 File filter Filter by extension Filter by extension .json (4) .sol (4) .yml (1) No extension (1) dotfile (2) All 5 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace .github/workflows/lint-contracts.yml lint-contracts.yml Makefile Makefile contracts/.gitignore .gitignore contracts/.solhint.json .solhint.json contracts/.solhintignore .solhintignore contracts/package-lock.json package-lock.json contracts/package.json package.json contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json alignedlayer-deployed-anvil-state.json contracts/src/core/AlignedLayerServiceManager.sol AlignedLayerServiceManager.sol contracts/src/core/AlignedLayerServiceManagerStorage.sol AlignedLayerServiceManagerStorage.sol contracts/src/core/BatcherPaymentService.sol BatcherPaymentService.sol contracts/src/core/IAlignedLayerServiceManager.sol IAlignedLayerServiceManager.sol There are no files selected for viewing 29 changes: 29 additions & 0 deletions 29 .github/workflows/lint-contracts.yml Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,29 @@ name: Lint contracts on: push: branches: [main] pull_request: branches: ["*"] paths: - "contracts/src/core/*.sol" - ".github/workflows/lint-contracts.yml" jobs: lint: runs-on: ubuntu-latest steps: - name: Checkout code uses: actions/checkout@v2 - name: Set up Node.js uses: actions/setup-node@v4 with: node-version: "20" - name: Install dependencies run: npm install working-directory: contracts - name: Run Solhint run: npm run lint:sol working-directory: contracts 9 changes: 9 additions & 0 deletions 9 Makefile Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,6 +71,9 @@ anvil_upgrade_index_registry: @echo "Upgrading Index Registry Contracts..." . contracts/scripts/anvil/upgrade_index_registry.sh lint_contracts: @cd contracts && npm run lint:sol anvil_start: @echo "Starting Anvil..." anvil --load-state contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json Expand DownExpand Up @@ -441,6 +444,12 @@ upgrade_batcher_payment_service: build_aligned_contracts: @cd contracts/src/core && forge build show_aligned_error_codes: @echo "\nAlignedLayerServiceManager errors:" @cd contracts/src/core && forge inspect IAlignedLayerServiceManager.sol:IAlignedLayerServiceManager errors @echo "\nBatcherPaymentService errors:" @cd contracts/src/core && forge inspect BatcherPaymentService.sol:BatcherPaymentService errors __BUILD__: build_binaries: @echo "Building aggregator..." Expand Down 1 change: 1 addition & 0 deletions 1 contracts/.gitignore Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -15,3 +15,4 @@ docs/ data/ node_modules/ 13 changes: 13 additions & 0 deletions 13 contracts/.solhint.json Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1,13 @@ { "extends": "solhint:recommended", "rules": { "func-visibility": [ "warn", { "ignoreConstructors": true } ], "no-complex-fallback": "off", "func-name-mixedcase": "off" } } 1 change: 1 addition & 0 deletions 1 contracts/.solhintignore Show comments View file Open in desktop Original file line number Diff line number Diff line change @@ -0,0 +1 @@ src/core/ERC20Mock.sol Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time.