') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat: add withdraw method for batchers in servicemanager by NicolasRampoldi · Pull Request #872 · yetanotherco/aligned_layer · GitHub
Skip to content

feat: add withdraw method for batchers in servicemanager - #872

Merged
NicolasRampoldi merged 4 commits into
mainfrom
870-add-withdraw-method-for-batchers-in-servicemanager
Aug 27, 2024
Merged

feat: add withdraw method for batchers in servicemanager#872
NicolasRampoldi merged 4 commits into
mainfrom
870-add-withdraw-method-for-batchers-in-servicemanager

Conversation

@NicolasRampoldi

@NicolasRampoldiNicolasRampoldi commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

Description

  • Adds withdraw method for batchers in AlignedLayerServiceManager.

To Test

  • First, fund the batcher in the AlignedLayerServiceManager:
cast send <aligned_layer_service_manager_addr> --value 1ether --private-key <batcher_private_key>
  • Then, check the funds:
cast call <aligned_layer_service_manager_addr> "balanceOf(address)(uint256)" <batcher_addr>
  • Then, withdraw the funds:
cast send <aligned_layer_service_manager_addr> "withdraw(uint256)" 0.5ether --private-key <batcher_private_key>
  • Lastly, check the funds again:
cast call <aligned_layer_service_manager_addr> "balanceOf(address)(uint256)" <batcher_addr>

@NicolasRampoldiNicolasRampoldi linked an issue Aug 27, 2024 that may be closed by this pull request
Add withdraw method for Batchers in ServiceManager #870
Closed
@NicolasRampoldiNicolasRampoldi self-assigned this Aug 27, 2024
@github-actions

github-actionsBot commented Aug 27, 2024•
edited
Loading

Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 620f0e09204a4255ab5498a8384bbde518e18326, compared to commit: 61624d9f47e04ec153c619990967357ba4d09acb

🧾 Summary (10% most significant diffs)

ContractMethodAvg (+/-)%
AlignedLayerServiceManagerreceive+33 ❌+0.07%
Full diff report 👇
ContractDeployment Cost (+/-)MethodMin (+/-)%Avg (+/-)%Median (+/-)%Max (+/-)%# Calls (+/-)
AlignedLayerServiceManager4,412,695 (+53,659)receive44,965 (+33)+0.07%44,965 (+33)+0.07%44,965 (+33)+0.07%44,965 (+33)+0.07%256 (0)

@NicolasRampoldi
NicolasRampoldiforce-pushed the 870-add-withdraw-method-for-batchers-in-servicemanager branch from 5aa96a2 to e2b4a5bCompareAugust 27, 2024 17:41
entropidelic
entropidelic reviewed Aug 27, 2024
View reviewed changes
Comment threadcontracts/src/core/IAlignedLayerServiceManager.sol Outdated
@NicolasRampoldi
NicolasRampoldi merged commit 2274416 into mainAug 27, 2024
@NicolasRampoldi
NicolasRampoldi deleted the 870-add-withdraw-method-for-batchers-in-servicemanager branch August 27, 2024 19:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@uri-99uri-99uri-99 approved these changes
@entropidelicentropidelicentropidelic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@NicolasRampoldiNicolasRampoldi

Labels

auditdue-diligence

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add withdraw method for Batchers in ServiceManager

4 participants

@NicolasRampoldi@uri-99@entropidelic@JuArce