Uh oh!
There was an error while loading. Please reload this page.
feat: add limit on aggregator spending - #910
Conversation
taturosati
left a comment
There was a problem hiding this comment.
just refactors, I think code looks good, need to test thoroughly
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
taturosati
left a comment
There was a problem hiding this comment.
Happy path is not working, getting revert with 0x5c54305e0000000000000000000000007969c5ed335650692bc04293b07f5bf2e7a673c00000000000000000000000000000000000000000000000000002e357ab61e200000000000000000000000000000000000000000000000000000171abd5b0f100 which is InsufficientFunds
More info regarding this, doing a cast send does not fix this issue. I think the cause of this is that the batcher payment service needs to have balance and not the batcher itself. I had to change the multiplier to 1 for some batches to get it started. This gives it some balance for it to have enough for the 2x multiplier. Possible solution to this is adding a method on the batcher payment service to fund itself on the aligned service manager (which would basically be a transfer from contract to contract). |
uri-99
commented
Sep 5, 2024
@taturosati |
…nd RespondToTaaskFeeLimit
This PR
max_fee_allowed_to_respond.lib.rsasMAX_FEE_FOR_AGGREGATOR_MULTIPLIER, where it is used to multiply it tofee_for_aggregator, to get themax_fee_allowed_to_respond.max_fee_allowed_to_respond, to respond that taskTo Deploy
This PR changes no memory, so a normal upgrade must be run for both AlignedLayerServiceManager and BatcherPaymentService.
To Test
Happy Path
And when they finish starting up, you can send proofs:
Playing around max_fee_allowed_to_respond
For this you can do, for example:
BatcherPaymentServiceand check it behaves accordingly.AlignedServiceManager, and check it behaves accordingly.