Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Fix operator merkle root retrocompatibility by uri-99 · Pull Request #996 · yetanotherco/aligned_layer · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/build-go.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,8 @@ jobs:
run: make build_halo2_ipa_linux
- name: Build Merkle Tree bindings
run: make build_merkle_tree_linux
- name: Build Old Merkle Tree bindings
run: make build_merkle_tree_linux_old
- name: Build operator
run: go build operator/cmd/main.go
- name: Build aggregator
Expand Down
24 changes: 24 additions & 0 deletions Makefile
Original file line numberDiff line numberDiff line change
Expand Up@@ -541,15 +541,29 @@ build_merkle_tree_macos:
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree/lib/libmerkle_tree.dylib
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_macos_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.dylib operator/merkle_tree_old/lib/libmerkle_tree.dylib
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

build_merkle_tree_linux:
@cd operator/merkle_tree/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree/lib/libmerkle_tree.so
@cp operator/merkle_tree/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree/lib/libmerkle_tree.a

build_merkle_tree_linux_old:
@cd operator/merkle_tree_old/lib && cargo build $(RELEASE_FLAG)
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.so operator/merkle_tree_old/lib/libmerkle_tree.so
@cp operator/merkle_tree_old/lib/target/$(TARGET_REL_PATH)/libmerkle_tree.a operator/merkle_tree_old/lib/libmerkle_tree.a

test_merkle_tree_rust_ffi:
@echo "Testing Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_rust_ffi_old:
@echo "Testing Old Merkle Tree Rust FFI source code..."
@cd operator/merkle_tree_old/lib && RUST_MIN_STACK=83886080 cargo t --release

test_merkle_tree_go_bindings_macos: build_merkle_tree_macos
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v
Expand All@@ -558,6 +572,14 @@ test_merkle_tree_go_bindings_linux: build_merkle_tree_linux
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree/... -v

test_merkle_tree_old_go_bindings_macos: build_merkle_tree_macos_old
@echo "Testing Old Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

test_merkle_tree_go_bindings_linux_old: build_merkle_tree_linux_old
@echo "Testing Merkle Tree Go bindings..."
go test ./operator/merkle_tree_old/... -v

__HALO2_KZG_FFI__: ##
build_halo2_kzg_macos:
@cd operator/halo2kzg/lib && cargo build $(RELEASE_FLAG)
Expand DownExpand Up@@ -632,6 +654,7 @@ build_all_ffi_macos: ## Build all FFIs for macOS
@$(MAKE) build_sp1_macos
@$(MAKE) build_risc_zero_macos
@$(MAKE) build_merkle_tree_macos
@$(MAKE) build_merkle_tree_macos_old
@$(MAKE) build_halo2_ipa_macos
@$(MAKE) build_halo2_kzg_macos
@echo "All macOS FFIs built successfully."
Expand All@@ -641,6 +664,7 @@ build_all_ffi_linux: ## Build all FFIs for Linux
@$(MAKE) build_sp1_linux
@$(MAKE) build_risc_zero_linux
@$(MAKE) build_merkle_tree_linux
@$(MAKE) build_merkle_tree_linux_old
@$(MAKE) build_halo2_ipa_linux
@$(MAKE) build_halo2_kzg_linux
@echo "All Linux FFIs built successfully."
Expand Down
2 changes: 1 addition & 1 deletion aggregator/internal/pkg/subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,7 @@ func (agg *Aggregator) SubscribeToNewTasks() error {
func (agg *Aggregator) subscribeToNewTasks() error {
var err error

agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasks(agg.NewBatchChan)
agg.taskSubscriber, err = agg.avsSubscriber.SubscribeToNewTasksV3(agg.NewBatchChan)

if err != nil {
agg.AggregatorConfig.BaseConfig.Logger.Info("Failed to create task subscriber", "err", err)
Expand Down
202 changes: 191 additions & 11 deletions core/chainio/avs_subscriber.go
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,19 +64,87 @@ func NewAvsSubscriberFromConfig(baseConfig *config.BaseConfig) (*AvsSubscriber,
logger: baseConfig.Logger,
}, nil
}

func (s *AvsSubscriber) SubscribeToNewTasksV2(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2)

// Subscribe to new tasks
sub, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

// create a new channel to foward errors
errorChannel := make(chan error)

pollLatestBatchTicker := time.NewTicker(PollLatestBatchInterval)

// Forward the new tasks to the provided channel
go func() {
defer pollLatestBatchTicker.Stop()
newBatchMutex := &sync.Mutex{}
batchesSet := make(map[[32]byte]struct{})
for {
select {
case newBatch := <-internalChannel:
s.processNewBatchV2(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereumV2()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatchV2(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

}()

// Handle errors and resubscribe
go func() {
for {
select {
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasksV2(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
}
}
}()

return errorChannel, nil
}

func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
func (s *AvsSubscriber) SubscribeToNewTasksV3(newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) (chan error, error) {
// Create a new channel to receive new tasks
internalChannel := make(chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3)

// Subscribe to new tasks
sub, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
}

subFallback, err := subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err := subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
s.logger.Error("Failed to subscribe to new AlignedLayer tasks", "err", err)
return nil, err
Expand All@@ -95,14 +163,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
for {
select {
case newBatch := <-internalChannel:
s.processNewBatch(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(newBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
case <-pollLatestBatchTicker.C:
latestBatch, err := s.getLatestTaskFromEthereum()
latestBatch, err := s.getLatestTaskFromEthereumV3()
if err != nil {
s.logger.Debug("Failed to get latest task from blockchain", "err", err)
continue
}
s.processNewBatch(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
s.processNewBatchV3(latestBatch, batchesSet, newBatchMutex, newTaskCreatedChan)
}
}

Expand All@@ -115,14 +183,14 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
case err := <-sub.Err():
s.logger.Warn("Error in new task subscription", "err", err)
sub.Unsubscribe()
sub, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
sub, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManager, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
case err := <-subFallback.Err():
s.logger.Warn("Error in fallback new task subscription", "err", err)
subFallback.Unsubscribe()
subFallback, err = subscribeToNewTasks(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
subFallback, err = subscribeToNewTasksV3(s.AvsContractBindings.ServiceManagerFallback, internalChannel, s.logger)
if err != nil {
errorChannel <- err
}
Expand All@@ -133,7 +201,29 @@ func (s *AvsSubscriber) SubscribeToNewTasks(newTaskCreatedChan chan *servicemana
return errorChannel, nil
}

func subscribeToNewTasks(
func subscribeToNewTasksV2(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2,
logger sdklogging.Logger,
) (event.Subscription, error) {
for i := 0; i < MaxRetries; i++ {
sub, err := serviceManager.WatchNewBatchV2(
&bind.WatchOpts{}, newTaskCreatedChan, nil,
)
if err != nil {
logger.Warn("Failed to subscribe to new AlignedLayer tasks", "err", err)
time.Sleep(RetryInterval)
continue
}

logger.Info("Subscribed to new AlignedLayer tasks")
return sub, nil
}

return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func subscribeToNewTasksV3(
serviceManager *servicemanager.ContractAlignedLayerServiceManager,
newTaskCreatedChan chan *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3,
logger sdklogging.Logger,
Expand All@@ -155,7 +245,7 @@ func subscribeToNewTasks(
return nil, fmt.Errorf("failed to subscribe to new AlignedLayer tasks after %d retries", MaxRetries)
}

func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
func (s *AvsSubscriber) processNewBatchV2(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV2) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

Expand All@@ -181,10 +271,100 @@ func (s *AvsSubscriber) processNewBatch(batch *servicemanager.ContractAlignedLay
}
}

func (s *AvsSubscriber) processNewBatchV3(batch *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, batchesSet map[[32]byte]struct{}, newBatchMutex *sync.Mutex, newTaskCreatedChan chan<- *servicemanager.ContractAlignedLayerServiceManagerNewBatchV3) {
newBatchMutex.Lock()
defer newBatchMutex.Unlock()

batchIdentifier := append(batch.BatchMerkleRoot[:], batch.SenderAddress[:]...)
var batchIdentifierHash = *(*[32]byte)(crypto.Keccak256(batchIdentifier))

if _, ok := batchesSet[batchIdentifierHash]; !ok {
s.logger.Info("Received new task",
"batchMerkleRoot", hex.EncodeToString(batch.BatchMerkleRoot[:]),
"senderAddress", hex.EncodeToString(batch.SenderAddress[:]),
"batchIdentifierHash", hex.EncodeToString(batchIdentifierHash[:]),)

batchesSet[batchIdentifierHash] = struct{}{}
newTaskCreatedChan <- batch

// Remove the batch from the set after RemoveBatchFromSetInterval time
go func() {
time.Sleep(RemoveBatchFromSetInterval)
newBatchMutex.Lock()
delete(batchesSet, batchIdentifierHash)
newBatchMutex.Unlock()
}()
}
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereumV2() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV2, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get latest block number: %w", err)
}
}

var fromBlock uint64

if latestBlock < BlockInterval {
fromBlock = 0
} else {
fromBlock = latestBlock - BlockInterval
}

alignedLayerServiceManagerABI, err := abi.JSON(strings.NewReader(servicemanager.ContractAlignedLayerServiceManagerMetaData.ABI))
if err != nil {
return nil, fmt.Errorf("failed to parse ABI: %w", err)
}

// We just care about the NewBatch event
newBatchEvent := alignedLayerServiceManagerABI.Events["NewBatchV2"]
if newBatchEvent.ID == (ethcommon.Hash{}) {
return nil, fmt.Errorf("NewBatch event not found in ABI")
}

query := ethereum.FilterQuery{
FromBlock: big.NewInt(int64(fromBlock)),
ToBlock: big.NewInt(int64(latestBlock)),
Addresses: []ethcommon.Address{s.AlignedLayerServiceManagerAddr},
Topics: [][]ethcommon.Hash{{newBatchEvent.ID, {}}},
}

logs, err := s.AvsContractBindings.ethClient.FilterLogs(context.Background(), query)
if err != nil {
logs, err = s.AvsContractBindings.ethClientFallback.FilterLogs(context.Background(), query)
if err != nil {
return nil, fmt.Errorf("failed to get logs: %w", err)
}
}

if len(logs) == 0 {
return nil, fmt.Errorf("no logs found")
}

lastLog := logs[len(logs)-1]

var latestTask servicemanager.ContractAlignedLayerServiceManagerNewBatchV2
err = alignedLayerServiceManagerABI.UnpackIntoInterface(&latestTask, "NewBatchV2", lastLog.Data)
if err != nil {
return nil, fmt.Errorf("failed to unpack log data: %w", err)
}

// The second topic is the batch merkle root, as it is an indexed variable in the contract
latestTask.BatchMerkleRoot = lastLog.Topics[1]

return &latestTask, nil
}

// getLatestTaskFromEthereum queries the blockchain for the latest task using the FilterLogs method.
// The alternative to this is using the FilterNewBatch method from the contract's filterer, but it requires
// to iterate over all the logs, which is not efficient and not needed since we only need the latest task.
func (s *AvsSubscriber) getLatestTaskFromEthereum() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
func (s *AvsSubscriber) getLatestTaskFromEthereumV3() (*servicemanager.ContractAlignedLayerServiceManagerNewBatchV3, error) {
latestBlock, err := s.AvsContractBindings.ethClient.BlockNumber(context.Background())
if err != nil {
latestBlock, err = s.AvsContractBindings.ethClientFallback.BlockNumber(context.Background())
Expand Down
2 changes: 2 additions & 0 deletions operator/merkle_tree_old/.gitignore
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
lib/libmerkle_tree.a
lib/libmerkle_tree.dylib
Loading