Skip to content
This repository was archived by the owner on Jul 19, 2020. It is now read-only.

6-8 Styling page, Move Nested components page - #87

Open
rlasjunies wants to merge 6 commits into
yewstack:masterfrom
rlasjunies:nested-components
Open

6-8 Styling page, Move Nested components page#87
rlasjunies wants to merge 6 commits into
yewstack:masterfrom
rlasjunies:nested-components

Conversation

@rlasjunies

Copy link
Copy Markdown

Remove of the CSS.md and add the Styling page
Move from html! the component page, rename it NestedComponents

Update summary

@rlasjuniesrlasjunies changed the title 6-8 Stylin page, Move Nested components6-8 Styling page, Move Nested componentsMay 8, 2020
@rlasjuniesrlasjunies changed the title 6-8 Styling page, Move Nested components6-8 Styling page, Move Nested components pageMay 8, 2020
Comment threadsrc/concepts/components/styling.md Outdated
Comment threadsrc/concepts/components/styling.md Outdated
Comment threadsrc/SUMMARY.md Outdated
* [Nested component](concepts/components/nestedcomponents.md)
* [Refs](concepts/components/refs.md)
* [Styling](concepts/components/styling.md)
* [Life cycle](concepts/components/lifecycle.md)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylistically, I think it's better for "life cycle" to be "lifecycle."

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ask myself about it and google it. Found more about "Life Cycle"
Anyway ... we are 2 having the same feeling => I change to 1 word

Comment threadsrc/concepts/components/nestedcomponents.md Outdated
Comment threadsrc/concepts/components/styling.md Outdated

## Yew component does not support yet class attribute

So far Yew component does not support natively the `class` attribute. You can add the class attribute to your component:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gramatically this should read more along the lines of "At the moment Yew's components don't natively support the class attribute."

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this limitation is now resolved with the 0.16 release with #1187
=> I remove the chapter

Comment threadsrc/concepts/components/styling.md Outdated
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rlasjunies@teymour-aldridge