Skip to content

Token classifier & refactor filters - #41

Merged
rustamwin merged 15 commits into
refactoringfrom
token-classifier
Oct 26, 2023
Merged

Token classifier & refactor filters#41
rustamwin merged 15 commits into
refactoringfrom
token-classifier

Conversation

@rustamwin

@rustamwinrustamwin commented Oct 20, 2023

Copy link
Copy Markdown
Member
QA
Is bugfix?
New feature?✔️
Breaks BC?✔️
Fixed issues#39

@codecov

codecovBot commented Oct 20, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2db3db7) 100.00% compared to head (527cdce) 100.00%.

Additional details and impacted files
@@ Coverage Diff @@## refactoring #41 +/- ##
================================================
Coverage 100.00% 100.00% - Complexity 24 73 +49 
================================================
Files 2 8 +6 Lines 60 175 +115 ================================================
+ Hits 60 175 +115 
FilesCoverage Δ
src/AbstractClassifier.php100.00% <100.00%> (ø)
src/Filter/ClassAttributes.php100.00% <100.00%> (ø)
src/Filter/ClassImplements.php100.00% <100.00%> (ø)
src/Filter/SubclassOf.php100.00% <100.00%> (ø)
src/Filter/TargetAttribute.php100.00% <100.00%> (ø)
src/NativeClassifier.php100.00% <100.00%> (ø)
src/ReflectionFile.php100.00% <100.00%> (ø)
src/TokenizerClassifier.php100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustamwin
rustamwin marked this pull request as draft October 20, 2023 11:33
@xepozz

Copy link
Copy Markdown
Member

Please don't forget to compare benchmarks

@rustamwinrustamwin mentioned this pull request Oct 20, 2023
@rustamwin
rustamwin marked this pull request as ready for review October 22, 2023 13:54
@rustamwin
rustamwin requested a review from a teamOctober 22, 2023 13:55
@rustamwinrustamwin added the status:code review The pull request needs review. label Oct 22, 2023
@rustamwin

Copy link
Copy Markdown
MemberAuthor

ℹ️ The classifier now also finds interfaces, traits and enums.

@samdark

Copy link
Copy Markdown
Member

@rustamwin

Copy link
Copy Markdown
MemberAuthor

@rustamwin#41 (comment)?

I will do it within 1-2 days.

@rustamwin
rustamwin merged commit 76f5f2f into refactoringOct 26, 2023
@rustamwin
rustamwin deleted the token-classifier branch October 26, 2023 14:36
@rustamwin

Copy link
Copy Markdown
MemberAuthor

Benchmark results here: #38 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code reviewThe pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rustamwin@xepozz@samdark@StyleCIBot