Uh oh!
There was an error while loading. Please reload this page.
Remove Schema::getSchemaDefaultValues() - #428
Open
KalimeroMK wants to merge 2 commits into
Open
Conversation
The method existed only to satisfy ConstraintSchemaInterface by throwing NotSupportedException. yiisoft/db removes that declaration, leaving this override with nothing to implement. BREAKING CHANGE: Yiisoft\Db\Sqlite\Schema::getSchemaDefaultValues() is gone. Use getTableDefaultValues() per table instead, which SQLite does support. Refs yiisoft/db#1175
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #428 +/- ##
============================================
- Coverage 98.48% 98.48% -0.01% + Complexity 329 328 -1
============================================
Files 22 22 Lines 1055 1053 -2 ============================================
- Hits 1039 1037 -2
Misses 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tigrov
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to yiisoft/db#1175, which removes
getSchemaDefaultValues()fromConstraintSchemaInterface. This override existed only to satisfy that declaration by throwingNotSupportedException, so it implements nothing once the declaration is gone.Unlike the other drivers, SQLite does not break without this — the override keeps the call resolvable, so this is cleanup and can merge in any order.
loadTableDefaultValues()still throws and is covered throughgetTableDefaultValues().