Skip to content

Fix #888 issue - #948

Open
evil1 wants to merge 152 commits into
yiisoft:masterfrom
evil1:batchInsert
Open

Fix #888 issue#948
evil1 wants to merge 152 commits into
yiisoft:masterfrom
evil1:batchInsert

Conversation

@evil1

@evil1evil1 commented Mar 28, 2025

Copy link
Copy Markdown
Contributor
QA
Is bugfix?✔️
New feature?
Breaks BC?✔️
Fixed issues#888

Relative PRs:

@codecov

codecovBot commented Mar 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.18%. Comparing base (43abebf) to head (b41aa4c).
⚠️ Report is 180 commits behind head on master.

Files with missing linesPatch %Lines
src/QueryBuilder/AbstractDMLQueryBuilder.php96.72%2 Missing ⚠️
src/QueryBuilder/AbstractQueryBuilder.php66.66%2 Missing ⚠️
src/Command/AbstractCommand.php90.90%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #948 +/- ##
============================================
- Coverage 99.24% 99.18% -0.07% - Complexity 1554 1571 +17 
============================================
Files 98 100 +2 Lines 3852 3913 +61 ============================================
+ Hits 3823 3881 +58 - Misses 29 32 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjikvjik added the status:under development Someone is working on a pull request. label Apr 16, 2025
final class BatchCommand
{
/**
* @param CommandInterface[] $commands Query statements for execution

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param CommandInterface[] $commands Query statements for execution
* @param CommandInterface[] $commands Query statements for execution.

}

/**
* @return ConnectionInterface The query builder instance.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return ConnectionInterface The query builder instance.
* @return ConnectionInterface The connection instance.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under developmentSomeone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@evil1@Tigrov@samdark@vjik