Skip to content

Introduce handler resolver - #327

Open
vjik wants to merge 5 commits into
masterfrom
message-handler-resolver
Open

Introduce handler resolver#327
vjik wants to merge 5 commits into
masterfrom
message-handler-resolver

Conversation

@vjik

@vjikvjik commented Aug 14, 2026

Copy link
Copy Markdown
Member
QA
Is bugfix?
New feature?
Breaks BC?✔️
Tests pass?✔️

@codecov

codecovBot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.45%. Comparing base (82dd022) to head (89789bc).

Files with missing linesPatch %Lines
src/Message/Handler/HandlerResolver.php97.50%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #327 +/- ##
============================================
- Coverage 92.51% 92.45% -0.06% - Complexity 379 387 +8 
============================================
Files 55 59 +4 Lines 988 1021 +33 ============================================
+ Hits 914 944 +30 - Misses 74 77 +3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik
vjik requested a review from a teamAugust 14, 2026 09:00
@vjikvjik added the status:code review The pull request needs review. label Aug 14, 2026

public function handle(MessageInterface $message): void
{
($this->handler)($message);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use injector as it was previously.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@vjik
vjik requested a review from samdarkAugust 18, 2026 07:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code reviewThe pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vjik@samdark