Uh oh!
There was an error while loading. Please reload this page.
Add yklocations to recursive-via-tail-call functions. - #151
Merged
Conversation
Before this commit, tail calls bypassed our "spot recursive functions and add a `YkLocation` to them" check. The `p->called` in this commit fixes that problem _but_ we then need to account for the fact that this means the caller function has implicitly returned: if it _isn't_ the current function we need to mark it as uncalled. As before, this heuristic isn't perfect, but it solves an obvious limitation in yklua, though it doesn't make much difference to actual benchmarks.
ltratt
enabled auto-merge
July 21, 2026 14:50
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, tail calls bypassed our "spot recursive functions and add a
YkLocationto them" check. Thep->calledin this commit fixes that problem but we then need to account for the fact that this means the caller function has implicitly returned: if it isn't the current function we need to mark it as uncalled.As before, this heuristic isn't perfect, but it solves an obvious limitation in yklua, though it doesn't make much difference to actual benchmarks.