refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

refactor(backend): GitHubLinkCache の直クエリを repository へ集約 - #421

Merged
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo
Jun 27, 2026
Merged

refactor(backend): GitHubLinkCache の直クエリを repository へ集約#421
yusuke0610 merged 1 commit into
mainfrom
refactor/github-link-cache-repo

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jun 27, 2026

Copy link
Copy Markdown
Owner

概要

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。GitHubLinkCachefilter_by(user_id=...) 直クエリが router / service / handler / context_builder の 9 箇所に散在していた負債を解消する。

変更内容

High: GitHubLinkCacheRepository へ集約

  • repositories/github_link.py(新規)に GitHubLinkCacheRepository を新設(get_by_user / get_or_create)。get_or_create は IntegrityError → rollback → 再 SELECT、None なら RuntimeErrordatabase.md「IntegrityError 後の再 SELECT は None を判定」準拠)。
  • 9 箇所の直クエリを repository 経由へ置換し、layers.md パターン B(router への DB クエリ直書き)違反を解消。

Medium

  • routers/github_link.py を package 化(__init__ / endpoints / _responses)。HTTP 出力整形 to_skill_item_responses.py へ分離(duplication.md ヒエラルキー準拠)。__init__router を re-export するため呼び出し側は無改修。
  • chat_service.run_agent_chat の「LLM 呼び出し + トークン加算 + ログ」を内部ヘルパ _generate_and_account へ集約。ADR-0012 の課金合算・失敗時使用量伝播は不変

テスト

  • tests/test_github_link_cache_repository.py(新規・5 ケース)。正常系に加え、競合パス(IntegrityError → 再 SELECT で既存行返却 / 再 SELECT None で RuntimeError)を実 SQLite セッションで検証。

補足

  • app/db/bootstrap.py の bulk status クリーンアップ(cross-user・status フィルタ)は user_id 単一行 API の責務外のため対象外(次 PR 候補)。
  • レポートの Low は「現状維持が正解」のため見送り。

検証

  • make lint-backend: pass
  • make test-backend: pass(632 passed)
  • make codegen-types: web/src/api/generated.ts 差分なし(OpenAPI drift なし)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Improved GitHub link handling across the app, including safer cache creation and reuse.
    • GitHub skill results are now formatted more consistently in API responses.
  • Bug Fixes

    • Reduced duplicate cache records during concurrent requests.
    • Standardized progress, retry, and status checks for GitHub link workflows.
  • Tests

    • Added coverage for cache lookup, creation, race conditions, and error handling.

BE_refacter の指摘(report/BE_report_20260627_2044.md)の High + Medium を適用。
- repositories/github_link.py に GitHubLinkCacheRepository を新設
(get_by_user / get_or_create)。get_or_create は IntegrityError 後の
再 SELECT が None なら RuntimeError を上げる(database.md 準拠)
- 9 箇所の直クエリ(router/service/handler/context_builder)を repository
経由へ置換し layers.md パターン B 違反を解消
- routers/github_link.py を package 化し、HTTP 出力整形 to_skill_item を
_responses.py へ分離
- chat_service.run_agent_chat の「呼び出し+トークン加算+ログ」を内部ヘルパへ
集約(ADR-0012 課金契約は不変)
- get_or_create の競合パス単体テストを追加
make lint-backend / make test-backend(632 passed) / codegen-drift いずれも green。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4278411b-9ecd-473f-8057-e67ce0ec3829

📥 Commits

Reviewing files that changed from the base of the PR and between 18131b7 and 728e1cf.

📒 Files selected for processing (10)
  • backend/app/repositories/__init__.py
  • backend/app/repositories/github_link.py
  • backend/app/routers/github_link/__init__.py
  • backend/app/routers/github_link/_responses.py
  • backend/app/routers/github_link/endpoints.py
  • backend/app/services/agent/chat_service.py
  • backend/app/services/agent/context_builder.py
  • backend/app/services/intelligence/github_link_service.py
  • backend/app/services/tasks/handlers/github_link.py
  • backend/tests/test_github_link_cache_repository.py

📝 Walkthrough

Walkthrough

GitHub link cache access now goes through a repository layer across HTTP routes, services, and handlers, with new skill-to-response mapping and repository tests. Agent chat generation now shares token accounting across initial and retry calls.

Changes

GitHub link cache refactor

Layer / File(s)Summary
Repository implementation and tests
backend/app/repositories/github_link.py, backend/app/repositories/__init__.py, backend/tests/test_github_link_cache_repository.py
GitHubLinkCacheRepository provides get_by_user and get_or_create, the package exports the repository, and SQLite tests cover absent rows, create-on-miss, existing-row reuse, IntegrityError retry, and runtime error on failed re-select.
Router wiring and response mapping
backend/app/routers/github_link/__init__.py, backend/app/routers/github_link/_responses.py, backend/app/routers/github_link/endpoints.py
The GitHub link router package exports router, to_skill_item maps skills to API schemas, and cache, status, skills, and retry endpoints call the repository or shared mapper.
Service and handler lookups
backend/app/services/agent/context_builder.py, backend/app/services/intelligence/github_link_service.py, backend/app/services/tasks/handlers/github_link.py
GitHub context building, intelligence phases, and task handler record access switch to GitHubLinkCacheRepository; github_link_service.py also wraps get_or_create.

Agent chat accounting

Layer / File(s)Summary
Shared generation accounting
backend/app/services/agent/chat_service.py
run_agent_chat uses _generate_and_account for initial and retry generations, accumulates token usage from client.generate, logs response length, and re-raises retry LLMError with the accumulated usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • yusuke0610/devforge#325: Also updates the GitHub link cache access flow across router and service code paths, so it touches the same lookup/create call sites.

Poem

(_/)
I hop through caches, tidy and bright,
With rabbit paws I stitch the route just right.
Tokens dance, then settle in a row,
And GitHub skills now sparkle as they flow.
Hooray for code that bounds along the night!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: centralizing GitHubLinkCache queries into a repository.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/github-link-cache-repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yusuke0610
yusuke0610 merged commit 395b512 into mainJun 27, 2026
17 checks passed
@yusuke0610
yusuke0610 deleted the refactor/github-link-cache-repo branch July 20, 2026 12:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610