docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537

Merged
yusuke0610 merged 1 commit into
mainfrom
feat/pdf-import-adr
Jul 22, 2026
Merged

docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom
feat/pdf-import-adr

Conversation

@yusuke0610

@yusuke0610yusuke0610 commented Jul 22, 2026

Copy link
Copy Markdown
Owner

概要

手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。

決定内容

ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。

代替案（却下理由）

  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断

テスト

make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。

🤖 Generated with Claude Code

@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yusuke0610, you've reached your PR review limit, so we couldn't start this review.

Next review available in:13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47

📥 Commits

Reviewing files that changed from the base of the PR and between 1749be5 and abae783.

📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pdf-import-adr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added the documentation Improvements or additions to documentation label Jul 22, 2026
@yusuke0610yusuke0610 mentioned this pull request Jul 22, 2026
Merged
@yusuke0610
yusuke0610 merged commit 1120e8d into mainJul 22, 2026
21 checks passed
This was referenced Jul 25, 2026
Merged
Closed
@yusuke0610
yusuke0610 deleted the feat/pdf-import-adr branch July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526） - #537
Merged
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Jul 22, 2026
Merged
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 / #526）#537
yusuke0610 merged 1 commit into
mainfrom 
feat/pdf-import-adr
Conversation
@yusuke0610
@yusuke0610yusuke0610
commented
Jul 22, 2026

Copy link


Copy Markdown

Owner
概要
手持ち PDF 経歴書のフォーム流し込み機能（#517 のコールドスタート問題解消）の設計判断を ADR-0024 として起票する。PR 1本目 / ADR のみ（#527 backend・#528 web が後続）。
決定内容
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する。旧設計の敗因（generate() が失敗時に空文字を返し UI にエラーが届かなかった）を契約で構造的に封じる。
代替案（却下理由）
  • 非同期化（ADR-0020）: 抽出+1コールは同期 60s 内。タスク基盤は過剰
  • pdfplumber / PyMuPDF: 依存過多 / AGPL・native 依存
  • v1 で OCR: コスト・失敗モードが別物。将来判断
テスト
make lint-adr-index green（ADR ファイル ↔ 索引・系統図の drift なし）。docs のみの変更。
🤖 Generated with Claude Code
@yusuke0610@claude
docs(adr): 手持ち PDF 経歴書のフォーム流し込み ADR を起票（ADR-0024 /#526）
abae783
ADR-0004 で導入し ADR-0008 で撤去した「PDF 経歴書の AI 抽出」を、ADR-0010 の
不変条件（DB 非更新・明示的エラー契約）と ADR-0023 の Haiku 固定の上で再導入する
設計判断を記録。空フォーム離脱の解消（コールドスタート問題）が動機。
決定:
- v1 はテキスト埋め込み PDF のみ（スキャンは判定して日本語エラー）
- 抽出は pypdf（純 Python・MIT・native 依存なし）を == 固定で追加
- 同期エンドポイント POST /agent/resume-import/pdf（multipart）→ Resume 互換
payload 即返却・DB 非更新でフォーム注入機構（#524）へ渡す
- エラー契約で旧敗因（空文字握りつぶし）を構造的に封じる
- レート制限（#521）・アップロード検証（magic bytes / サイズ上限）を明記
docs/adr/README.md 索引・系統図も同一 PR で更新（make lint-adr-index green）。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai
coderabbitaiBot
commented
Jul 22, 2026

Copy link


Copy Markdown

Warning
Review limit reached
@yusuke0610, you've reached your PR review limit, so we couldn't start this review.
Next review available in:13 minutes
Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

You're only billed for reviews past your plan's rate limits ($0.25/file).
How can I continue?
After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.
To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.
How do review limits work?
CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.
For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.
Please refer docs for additional details.
Review details
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16e16fec-a85f-4792-94cc-a7f89ac15e47
📥 Commits
Reviewing files that changed from the base of the PR and between 1749be5 and abae783.
📒 Files selected for processing (2)
  • docs/adr/0024-pdf-resume-import.md
  • docs/adr/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch feat/pdf-import-adr
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands.
@github-actionsgithub-actionsBot
added
the 
documentation
Improvements or additions to documentation
label
Jul 22, 2026
@yusuke0610yusuke0610
mentioned this pull request
Jul 22, 2026
 Merged

@yusuke0610
yusuke0610
merged commit 1120e8d
into
mainJul 22, 2026

21 checks passed


This was referenced Jul 25, 2026
 Merged


Closed

@yusuke0610
yusuke0610
deleted the

feat/pdf-import-adr

branch
July 28, 2026 03:31
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

documentationImprovements or additions to documentation

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@yusuke0610