fix file modes by brokkoli71 · Pull Request #2000 · zarr-developers/zarr-python

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

brokkoli71 · 2024-06-27T13:01:08Z

fixes#1978
according to docstrings of zarr.open the modes should do:

mode : {'r', 'r+', 'a', 'w', 'w-'}, optional
Persistence mode: 'r' means read only (must exist); 'r+' means
read/write (must exist); 'a' means read/write (create if doesn't
exist); 'w' means create (overwrite if exists); 'w-' means create
(fail if exists).

this PR implements and tests this behavior, so #1978 gets fixed

# Conflicts: # src/zarr/array.py

jhamman · 2024-07-01T22:20:11Z

Thanks @brokkoli71 for picking this up. What is the expected behavior of mode='w'? Should we have a Store.clear() method that we call in these cases?

brokkoli71 · 2024-07-02T09:12:17Z

good point, according to the docstrings: 'w' means create (overwrite if exists). So yes, would be probably a good idea to have a generalized Store.clear. I will have a look at that

d-v-b · 2024-07-02T10:46:55Z

I agree that a method for clearing a store is a good idea. Just bear in mind that this can be a performance bottleneck when deleting arrays with a lot of chunks, especially on remote storage. We should think about performance at some point.

brokkoli71 · 2024-07-03T10:12:29Z

I was wondering, if supporting mode='w' as create (overwrite if exists) is a good idea concerning the performance? what is the usecase of this mode? maybe it would be better to explicitly have a delete or clear method? or we should have a warning in the docstrings?

d-v-b · 2024-07-03T10:17:28Z

There's a lot of usage for create + overwrite -- if users are rapidly iterating on something, they already created an old array, but they want to save a new array with the same name + different datatype, then the easiest way to do this is via something like an overwrite option. Handling this via array the creation flow is more ergonomic than forcing users to go through a separate API.

Don't worry too much about the performance concerns with bulk deletion for now. We should make the API convenient, then worry about performance later. I only brought delete performance up because it's something that zarr python v2 didn't deal with, which caused me some headaches.

# Conflicts: # src/zarr/store/remote.py

This reverts commit 5f876d2.

# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

jhamman

this is looking great! Just a few final comments.

jhamman

One last comment and a suggestion on ensure_open that you can take or leave. Thanks again for pushing on this.

Co-authored-by: Joe Hamman <jhamman1@gmail.com>

jhamman · 2024-07-25T19:33:10Z

@brokkoli71 - happy to merge this if you can resolve the conflicts.

# Conflicts: # src/zarr/store/remote.py

joshmoore · 2024-07-26T15:23:06Z

Sadly still conflicting, @brokkoli71

# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

fix file modes
32e84eb

normanrz added the V3 label Jun 27, 2024

normanrz added this to the 3.0.0 milestone Jun 27, 2024

normanrz requested a review from jhamman June 27, 2024 13:12

normanrz assigned brokkoli71 Jun 27, 2024

d-v-b reviewed Jun 27, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 3 commits July 1, 2024 17:24

change store mode from literal to class of properties
6d66f2a

raise FileNotFoundError instead of KeyError
ab353c9

Merge branch 'refs/heads/master' into fix-file-modes
9d83b6e
# Conflicts: # src/zarr/array.py

brokkoli71 commented Jul 1, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 2 commits July 3, 2024 13:26

rename OpenMode to AccessMode
a964cb5

rename AccessMode parameters
1ff5861

jhamman mentioned this pull request Jul 3, 2024
[v3] Release 3.0.0.alpha.1 #2008
Closed

brokkoli71 added 7 commits July 3, 2024 16:56

enforce AccessMode for MemoryStore and RemoteStore
2340e8b

fix RemoteStore
cab827c

fix RemoteStore
b9f49b4

Merge remote-tracking branch 'origin/fix-file-modes' into fix-file-modes
8b37537
# Conflicts: # src/zarr/store/remote.py

formatting
1d46753

fix RemoteStore._exists
5f876d2

Revert "fix RemoteStore._exists"
218a527
This reverts commit 5f876d2.

jhamman reviewed Jul 3, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

brokkoli71 added 4 commits July 4, 2024 11:53

create async Store.open()
edd3630

make Store.open() classmethod
01e3fa2

async clear and root_exists in Store
f016d34

fix test_remote.py:test_basic
6dbf994

brokkoli71 added 2 commits July 5, 2024 13:21

fix RemoteStore.open
2c372aa

Merge branch 'refs/heads/master' into fix-file-modes
f921f9e
# Conflicts: # tests/v3/conftest.py # tests/v3/test_codecs.py

brokkoli71 requested a review from jhamman July 5, 2024 11:53

jhamman reviewed Jul 17, 2024
View reviewed changes

Comment threadtests/v3/test_api.py Outdated
Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 4 commits July 18, 2024 13:38

remove unnecessary import zarr in tests
f03e4da

rename root_exists to (not) empty, test and fix store.empty, store.clear
0c12510

mypy
7932593

Merge branch 'v3' into fix-file-modes
ef0aef8

brokkoli71 requested a review from jhamman July 18, 2024 13:40

jhamman approved these changes Jul 18, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated
Comment threadsrc/zarr/abc/store.py

brokkoli71and others added 2 commits July 20, 2024 18:36

incorporate feedback on store._open()
830dd7e
Co-authored-by: Joe Hamman <jhamman1@gmail.com>

rename store.ensure_open to store._ensure_open
3abfad6

Merge branch 'refs/heads/master' into fix-file-modes
7d75edc
# Conflicts: # src/zarr/store/remote.py

Merge branch 'refs/heads/master' into fix-file-modes
6616185
# Conflicts: # src/zarr/store/core.py # tests/v3/test_store/test_memory.py

normanrz merged commit 325786a into zarr-developers:v3Jul 26, 2024

brokkoli71 mentioned this pull request Aug 12, 2024
data wiped from MemoryStore after store.close + array[:]#2067
Closed
6 tasks

Uh oh!

Uh oh!

Conversation

brokkoli71 commented Jun 27, 2024

Uh oh!

Uh oh!

Uh oh!

jhamman commented Jul 1, 2024

Uh oh!

brokkoli71 commented Jul 2, 2024

Uh oh!

d-v-b commented Jul 2, 2024

Uh oh!

brokkoli71 commented Jul 3, 2024

Uh oh!

d-v-b commented Jul 3, 2024

Uh oh!

Uh oh!

jhamman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhamman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jhamman commented Jul 25, 2024

Uh oh!

joshmoore commented Jul 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

brokkoli71 commented Jun 27, 2024

Uh oh!

Uh oh!

Uh oh!

jhamman commented Jul 1, 2024

Uh oh!

brokkoli71 commented Jul 2, 2024

Uh oh!

d-v-b commented Jul 2, 2024

Uh oh!

brokkoli71 commented Jul 3, 2024

Uh oh!

d-v-b commented Jul 3, 2024

Uh oh!

Uh oh!

jhamman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhamman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jhamman commented Jul 25, 2024

Uh oh!

joshmoore commented Jul 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development