Uh oh!
There was an error while loading. Please reload this page.
remove outdated v2 source code and tests from v3 branch - #2182
Merged
Conversation
jhamman
requested review from
a team, d-v-b, normanrz and zarrdevelopers
and removed request for
d-v-b, normanrz and zarrdevelopersSeptember 13, 2024 21:33
jhamman
commented
Sep 13, 2024
| @@ -255,90 +238,6 @@ async def test_delete_empty_chunks(store: Store) -> None: | |||
| assert await store.get(f"{path}/c0/0", prototype=default_buffer_prototype()) is None | |||
| @pytest.mark.parametrize("store", ("local", "memory"), indirect=["store"]) | |||
| async def test_zarr_compat(store: Store) -> None: | |||
MemberAuthor
There was a problem hiding this comment.
drawing attention to this change which we added to develop confidence that we were doing backward compatible things.
We may consider replacing this with a new CI workflow / test suite that generates data w/ 2.18 and consumes it with the v3 branch.
Contributor
There was a problem hiding this comment.
Is it worth opening an issue to keep track of replacing this?
normanrz
approved these changes
Sep 14, 2024
normanrz
left a comment
Member
There was a problem hiding this comment.
Removing this is a major milestone in our prep for the v3 release. I think it is important to remove it to reduce confusion and to let the community help us identify compatibility issues that we still need to address.
Thanks @jhamman!
d-v-b
commented
Sep 14, 2024
Contributor
looks great, thanks joe! 🚀 |
Closed
dcherian added a commit
to dcherian/zarr-python
that referenced
this pull request
Sep 27, 2024
* v3: remove outdated v2 source code and tests from v3 branch (zarr-developers#2182) Fix/empty listdir (zarr-developers#2225) Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#2219) Added Attributes.asdict (zarr-developers#2221)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
zarr.v2namespace from the v3 branch. I'm moving forward with this based on discussions in #1849 and in the weekly developer meeting. I know there are remain varying views on the best way to minimize disruption for existing users of zarr 2.x so I'll leave this up for at least a week to give folks a chance to consider the consequences of this PR.closes#1849
cc @zarr-developers/python-core-devs
TODO: