document storage classes and some developer apis by jhamman · Pull Request #2279 · zarr-developers/zarr-python

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman · 2024-10-01T04:06:59Z

closes#2250

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

- port normalize_chunks from v2 - add array.store property - default to append in create

also fix failing ci

…nto fix/dask-compat

dstansby · 2024-10-02T06:38:27Z

Would be good to get this up to date with the v3 branch before reviewing

jhamman · 2024-10-02T14:27:18Z

I can rebase this today.

…nto doc/storage

…/storage

jhamman · 2024-10-07T06:06:10Z

Okay, @dstansby (and others), this is now ready for a review.

dstansby

I've left some comments - one big one, is why so many docstrings deleted? Is it because they're inherited? If so, would be good to include a # docstring inherited comment where they are inherited so others don't get confused in the future.

dstansby · 2024-10-09T19:49:45Z

+ Parameters
+ ----------
+ mode : AccessModeLiteral
+ One of 'r', 'r+', 'w', 'w-', 'a'.


Could we define these as a string somewhere, and then re-use it here and lower down by making the docstring a format string? I worry about lists like this getting out of sync if they're duplicated across docstrings.

I decided not to do that here because its just this one method. If we have a docstring template tool in the future, I think it would be great to bring that to bear here (and even more so on the Group/Array classes).

…nto doc/storage

…/storage

jhamman · 2024-10-10T23:48:42Z

@dstansby - ready for another review here.

dstansby

I think you can get rid of the custom docstring inheritance code (see my inline comment). Where a docstring is inherited though, please could you leave a # docstring inherited comment under the signature, to signal to others that come by later that a fresh docstring doesn't need writing.

dstansby · 2024-10-11T07:56:06Z

 raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")
+
+
+def _inherit_docstrings(cls: type[Any]) -> type[Any]:


Docstrings are already automatically inherited, e.g. see Store and LocalStore. So I think this isn't needed and can be gotten rid of.

…nto doc/storage

dstansby

Good for me - might be worth getting someone more familiar with v3 to look over the docstring contents?

dstansby · 2024-10-13T07:49:42Z

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

jhamman added 20 commits September 14, 2024 15:40

fix: zarr v2 compatability fixes
fe49f5f
- port normalize_chunks from v2 - add array.store property - default to append in create

move zarr.store to zarr.storage
9a1580b
also fix failing ci

make chunks a tuple
0d89912

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
d78e384
…nto fix/dask-compat

Apply suggestions from code review
e534279

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
dea4a3d
…nto fix/dask-compat

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
7800f38
…nto fix/dask-compat

more merge conflict resolution
93b61fc

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
88afe52
…nto fix/dask-compat

fixups
fb6752d

fixup zipstore
0b1dedc

Apply suggestions from code review
322918a

Apply suggestions from code review
a95d54a

add test
128eb53

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
3c170ef
…nto fix/dask-compat

extend test
54ab9ef

clean up parents
77f2938

debug race condition
2295d76

more debug
5879d67

document storage classes and some developer apis
f54f6f2

jhamman added documentation Improvements to the documentation V3 labels Oct 1, 2024

jhamman linked an issue Oct 1, 2024 that may be closed by this pull request
Add documentation for zarr.storage#2250
Closed
2 tasks

jhamman added 2 commits October 1, 2024 07:43

Update src/zarr/core/array.py
3940d22

Merge branch 'fix/dask-compat' into doc/storage
c9d1c50

jhamman marked this pull request as ready for review October 2, 2024 04:47

jhamman changed the base branch from fix/dask-compat to v3October 2, 2024 04:47

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
83fa3ac
…nto doc/storage

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
f2137fb
…/storage

Merge branch 'v3' into doc/storage
f44601b

dstansby suggested changes Oct 9, 2024
View reviewed changes

jhamman added 3 commits October 10, 2024 14:31

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
731c22a
…nto doc/storage

inherit docstrings from baseclass
4e93aa0

Merge branch 'doc/storage' of github.com:jhamman/zarr-python into doc…
dad94e2
…/storage

jhamman requested a review from dstansby October 10, 2024 23:48

fix sphinx warning
5477d32

jhamman mentioned this pull request Oct 11, 2024
Bump sphinx from 8.0.2 to 8.1.0 in the actions group #2331
Closed

dstansby suggested changes Oct 11, 2024
View reviewed changes

jhamman added 7 commits October 11, 2024 10:05

# docstring inherited
728d4f7

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
e293b47
…nto doc/storage

Merge branch 'v3' ofhttps://github.com/zarr-developers/zarr-pythoni…
cee730c
…nto doc/storage

add storage guide
3f7290f

add missing file
35a6428

update links
a78461e

Merge branch 'v3' into doc/storage
eff01ce

jhamman requested a review from dstansby October 11, 2024 21:29

Merge branch 'v3' into doc/storage
c1f0923

dstansby approved these changes Oct 12, 2024
View reviewed changes

dstansby merged commit d2dc162 into zarr-developers:v3Oct 13, 2024

jhamman added this to the 3.0.0 milestone Oct 17, 2024

		raise ValueError(f"Expected one of ('C', 'F'), got {data} instead.")


		def _inherit_docstrings(cls: type[Any]) -> type[Any]:

Uh oh!

Uh oh!

Conversation

jhamman commented Oct 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dstansby commented Oct 2, 2024

Uh oh!

jhamman commented Oct 2, 2024

Uh oh!

jhamman commented Oct 7, 2024

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhamman commented Oct 10, 2024

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

dstansby commented Oct 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

jhamman commented Oct 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dstansby commented Oct 2, 2024

Uh oh!

jhamman commented Oct 2, 2024

Uh oh!

jhamman commented Oct 7, 2024

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhamman commented Oct 10, 2024

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

jhamman commented Oct 1, 2024•
edited
Loading

jhamman commented Oct 1, 2024•
edited
Loading

jhamman commented Oct 1, 2024•
edited
Loading