Feature: store learns to delete prefixes when overwriting/creating hierarchy nodes by jhamman · Pull Request #2430 · zarr-developers/zarr-python

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman · 2024-10-22T13:43:15Z

This PR implements delete_dir teaches the Group and Array classes to use it when overwriting nodes in a hierarchy.

Also included here:
~~- delete_prefix - not used but perhaps we should just use it instead of delete_dir~~

changes list_prefix to return absolute paths instead of stripping prefix. Given that list_prefix was unused before, this wasn't very disruptive but calling it out so others can help decide if this is what we want.

Still needs:

new store tests for delete_dir
new group tests for edge cases around delete_dir

closes#2191
first steps toward #2108 and #2359

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
GitHub Actions have all passed
Test coverage is 100% (Codecov passes)

overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

…into feature/store_erase_prefix

…python into feature/store_erase_prefix

paraseba · 2024-10-23T23:23:58Z


+ async def delete_dir(self, prefix: str, recursive: bool = True) -> None:
+ """
+ Remove all keys and prefixes in the store that begin with a given prefix.


I think it would make life much easier for Store implementers if we declare that prefix will always be the path of a group or a array. Otherwise, all implementations need to deal with unnecessary edge cases like delete_dir("path/to/array/c/0") or worse.
Icechunk is an example of a store that could very cleanly and efficiently implement the case for a group/array prefix, but it would struggle to handle other prefixes.

What is the use case for recursive = False ? If zarr itself doesn't have one, I'd remove the argument.

I can see a use case for delete_dir("path/to/array/c/") (remove all chunks from an array) so I think we should allow that -- even if it makes life a little harder in icechunk.

That's totally fine. Let's document the three possible prefix cases, and say that stores are allowed to do undefined behavior for other prefixes

paraseba · 2024-10-23T23:33:34Z

+ if not self.supports_listing:
+ raise NotImplementedError
+ self._check_writable()
+ async for key in self.list_prefix(prefix):


Can we document what's the expected return value of list_prefix? Absolute vs. relative, final "/" or not, etc.

this is done in the list_prefix docstring

…into feature/store_erase_prefix

TomAugspurger · 2024-10-25T12:21:24Z

Looks good overall. I've been struggling a bit with whether Stores should be a bit more aware about the context the operation is occurring in (e.g. deleting a group vs a specific chunk of an array; I think this relates to the conversation at #2430 (comment)). But I think this is a good improvement on its own.

jhamman · 2024-10-28T16:10:31Z

@TomAugspurger / @d-v-b / @paraseba - any final comments here. I'd like to get this in ahead of the larger store mode refactor in #2442

d-v-b

looks good. regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores, since RemoteStore will return keys relative to its path attribute, and similarly LocalStore with its root attribute.

jhamman · 2024-10-28T16:59:18Z

regarding the change to list_prefix, I will note that the definition of "absolute paths" is a bit shaky across different stores

Would defining these as "relative to the root of the store" be clearer?

jhamman · 2024-11-05T04:53:29Z

pre-commit.ci autofix

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

jhamman added 7 commits October 21, 2024 11:07

fix(array): thread order parameter through to array __init__
64ad525

type fixes
8b706f2

move defaults
59d7f79

apply MemoryOrder type to ArrayV2Metadata
075b929

more more
b072545

more more more
8726734

feature(store,group,array): stores learn to delete prefixes when
858d4fb
overwriting nodes - add Store.delete_dir and Store.delete_prefix - update array and group creation methods to call delete_dir - change list_prefix to return absolue keys

jhamman marked this pull request as ready for review October 22, 2024 13:44

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/api/asynchronous.py

Merge branch 'main' into feature/store_erase_prefix
c367483

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/core/array.py

d-v-b reviewed Oct 22, 2024
View reviewed changes

Comment threadsrc/zarr/storage/local.py Outdated

jhamman added 4 commits October 23, 2024 06:10

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
a94e53c
…into feature/store_erase_prefix

fixup
9c173c1

Merge branch 'feature/store_erase_prefix' of github.com:jhamman/zarr-…
939fb53
…python into feature/store_erase_prefix

fixup
d7a6982

jhamman commented Oct 23, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

paraseba reviewed Oct 23, 2024
View reviewed changes

jhamman added 4 commits October 24, 2024 16:29

respond to review
c38c2f7

Merge branch 'main' ofhttps://github.com/zarr-developers/zarr-python…
fce2600
…into feature/store_erase_prefix

fixup
cafb46a

fixup
a1e71f1

jhamman requested review from TomAugspurger, d-v-b and dcherian October 25, 2024 00:04

jhamman mentioned this pull request Oct 28, 2024
Refactor: store mode and initialization #2442
Merged
6 tasks

Merge branch 'main' into feature/store_erase_prefix
0c14dd1

d-v-b approved these changes Oct 28, 2024
View reviewed changes

jhamman mentioned this pull request Oct 30, 2024
Store.delete has inconsistent implementations #2451
Open

jhamman commented Nov 5, 2024
View reviewed changes

Comment threadsrc/zarr/abc/store.py Outdated

Update src/zarr/abc/store.py
5677683

jhamman closed this Nov 5, 2024

jhamman reopened this Nov 5, 2024

style: pre-commit fixes
7e9ec76

jhamman merged commit a31046c into zarr-developers:mainNov 5, 2024

jhamman deleted the feature/store_erase_prefix branch November 5, 2024 04:58

Uh oh!

Uh oh!

Conversation

jhamman commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomAugspurger commented Oct 25, 2024

Uh oh!

jhamman commented Oct 28, 2024

Uh oh!

d-v-b left a comment

Choose a reason for hiding this comment

Uh oh!

jhamman commented Oct 28, 2024

Uh oh!

Uh oh!

jhamman commented Nov 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

jhamman commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomAugspurger commented Oct 25, 2024

Uh oh!

jhamman commented Oct 28, 2024

Uh oh!

d-v-b left a comment

Choose a reason for hiding this comment

Uh oh!

jhamman commented Oct 28, 2024

Uh oh!

Uh oh!

jhamman commented Nov 5, 2024

Uh oh!

jhamman commented Oct 22, 2024•
edited
Loading

jhamman commented Oct 22, 2024•
edited
Loading

jhamman commented Oct 22, 2024•
edited
Loading