Skip to content

Fix/windows int32 issue - #3151

Merged
d-v-b merged 12 commits into
zarr-developers:mainfrom
d-v-b:fix/windows-int32-issue
Jun 30, 2025
Merged

Fix/windows int32 issue#3151
d-v-b merged 12 commits into
zarr-developers:mainfrom
d-v-b:fix/windows-int32-issue

Conversation

@d-v-b

Copy link
Copy Markdown
Contributor

There's a windows-specific issue where np.dtype('i') is an instance of np.dtypes.IntDType instead of np.dtypes.Int32DType, which breaks dtype inference. This PR adds logic to the dtype inference for Int32 to handle this case, and adds a test that fails without that fix.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actionsgithub-actionsBot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 18, 2025
@github-actionsgithub-actionsBot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 18, 2025
@d-v-b
d-v-b requested a review from dstansbyJune 19, 2025 09:12
@dstansbydstansby added this to the 3.1.0 milestone Jun 19, 2025
@d-v-b
d-v-b requested a review from TomAugspurgerJune 24, 2025 19:34
@d-v-b
d-v-b requested a review from jhammanJune 26, 2025 09:07
@d-v-b

Copy link
Copy Markdown
ContributorAuthor

rtd build is failing but I can't replicate this locally...

@jhamman

Copy link
Copy Markdown
Member

docs should be fixed now. Thanks @d-v-b

@codecov

codecovBot commented Sep 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (bbdefac) to head (dacc079).
⚠️ Report is 130 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3151 +/- ##
=======================================
Coverage 94.47% 94.48% =======================================
Files 78 78 Lines 8604 8607 +3 =======================================
+ Hits 8129 8132 +3 
Misses 475 475 
Files with missing linesCoverage Δ
src/zarr/core/dtype/npy/int.py98.73% <100.00%> (+0.01%)⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@d-v-b@jhamman@dstansby