') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat: ZipStore accepts open binary file-like objects by jhamman · Pull Request #4187 · zarr-developers/zarr-python · GitHub
Skip to content

feat: ZipStore accepts open binary file-like objects - #4187

Merged
jhamman merged 1 commit into
zarr-developers:mainfrom
jhamman:feature/zipstore-file-like
Jul 28, 2026
Merged

feat: ZipStore accepts open binary file-like objects#4187
jhamman merged 1 commit into
zarr-developers:mainfrom
jhamman:feature/zipstore-file-like

Conversation

@jhamman

@jhammanjhamman commented Jul 26, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Allows constructing a ZipStore from any seekable binary reader, enabling zip archives on remote storage:

  • io objects (BytesIO, fsspec file objects) are used directly
  • minimal readers that are not io.IOBase instances and whose read() may return buffer-protocol objects rather than bytes (e.g. obstore.ReadableFile) are adapted via a small io.RawIOBase wrapper when opened for reading

clear()/move() raise NotImplementedError for file-object-backed stores.

For reviewers

This is the first of a series of Pull Requests toward #2943.

Author attestation

  • I am a human, these are my changes, and I have reviewed and understood every change and can explain why each is correct.

TODO

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman
jhammanforce-pushed the feature/zipstore-file-like branch from e980c52 to ebc18e5CompareJuly 26, 2026 04:22
@codecov

codecovBot commented Jul 26, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.87%. Comparing base (eefa424) to head (b5f99fb).

Additional details and impacted files
@@ Coverage Diff @@## main #4187 +/- ##
==========================================
+ Coverage 93.84% 93.87% +0.02% 
==========================================
Files 91 91 Lines 12549 12594 +45 ==========================================
+ Hits 11777 11822 +45 
Misses 772 772
Files with missing linesCoverage Δ
src/zarr/storage/_zip.py98.18% <100.00%> (+0.46%)⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jhamman
jhammanforce-pushed the feature/zipstore-file-like branch from ebc18e5 to dc84c55CompareJuly 26, 2026 04:59
d-v-b
d-v-b reviewed Jul 26, 2026
View reviewed changes
Comment threadsrc/zarr/storage/_zip.py Outdated
@jhamman
jhammanforce-pushed the feature/zipstore-file-like branch 2 times, most recently from 896d25b to 7d33da8CompareJuly 26, 2026 13:36
@jhamman
jhamman requested a review from d-v-bJuly 26, 2026 13:59
d-v-b
d-v-b reviewed Jul 27, 2026
View reviewed changes
Comment threadtests/test_store/test_zip.py
d-v-b
d-v-b reviewed Jul 27, 2026
View reviewed changes
Comment threadtests/test_store/test_zip.py
d-v-b
d-v-b reviewed Jul 27, 2026
View reviewed changes
Comment threadtests/test_store/test_zip.py Outdated
@jhamman
jhammanforce-pushed the feature/zipstore-file-like branch from 7d33da8 to ef00953CompareJuly 27, 2026 15:12
@jhamman@claude
feat: ZipStore accepts open binary file-like objects
b5f99fb
Allows constructing a ZipStore from any seekable binary reader, enabling
zip archives on remote storage:
- io objects (BytesIO, fsspec file objects) are used directly
- minimal readers that are not io.IOBase instances and whose read() may
return buffer-protocol objects rather than bytes (e.g.
obstore.ReadableFile) are adapted via a small io.RawIOBase wrapper
when opened for reading
clear()/move() raise NotImplementedError for file-object-backed stores.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jhamman
jhammanforce-pushed the feature/zipstore-file-like branch from 54fa1dd to b5f99fbCompareJuly 27, 2026 19:14
@jhamman
jhamman merged commit 0b72757 into zarr-developers:mainJul 28, 2026
42 of 45 checks passed
@jhammanjhamman mentioned this pull request Jul 28, 2026
Merged
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-v-bd-v-bd-v-b approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhamman@d-v-b