Collect JSON utility functions by jakirkham · Pull Request #430 · zarr-developers/zarr-python

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham · 2019-04-20T00:00:41Z

This refactors out the JSON utility functions created in PR ( #429 ) and moves them from zarr.meta to zarr.util. It also employs them in other places where the json module was being used directly. Should make it easier to leverage the buffer protocol as part of the loading process. Finally includes the encode step within json_dumps, which eliminates the need for it to be done every time json_dumps is called, which simplifies the code a bit.

TODO:

Add unit tests and/or doctests in docstrings
Add docstrings and API docs for any new/modified user-facing classes and functions
New/modified features documented in docs/tutorial.rst
Changes documented in docs/release.rst
Docs build locally (e.g., run tox -e docs)
AppVeyor and Travis CI passes
Test coverage is 100% (Coveralls passes)

As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

jakirkham · 2019-04-20T00:36:19Z

Planning on merging Monday evening if no comments.

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

jakirkham added 9 commits April 19, 2019 19:23

Move ensure_text_type to zarr.util
eaf9f63
As `ensure_text_type` is a more general utility function, go ahead and move it over to `zarr.util` and drop it from `zarr.meta`. Though make sure to import it into `zarr.meta` so that it can still be used there.

Move json_dumps to zarr.util
fce3cec
As `json_dumps` has broader use than just for metdata (e.g. attributes would also benefit from it), this moves `json_dumps` to `zarr.util`.

Move json_loads to zarr.util
3ae2531
As `json_loads` is more generally useful than just parsing metadata, move it over to `zarr.util`. Though ensure it is still imported in `zarr.meta`.

Use json_loads in ConsolidatedMetadataStore
3742f96
Should ensure that the `ConsolidatedMetadataStore` is able to handle loading JSON data in a standard way.

Use json_dumps to serialize attributes
c59a54f

Handle encode within json_dumps
47cff3e
As every use of `json_dumps` is followed by a call to `encode` to convert the string to bytes, go ahead and incorporate this step in `json_dumps`. Should make it a bit easier to use.

Drop encode from json_dumps output
05de729
As the `encode` step is now part of `json_dumps`, remove that step when using the `json_dumps` function.

Drop unneeded intermediates in json_dumps usage
f3dcbad
After moving `encode` within `json_dumps`, there were intermediate variables left over that weren't really needed. This drops them.

Update release note on JSON reading and writing
ad3f66f

jakirkham merged commit 48aa41d into zarr-developers:masterApr 23, 2019

jakirkham deleted the collect_util_funcs branch April 23, 2019 01:55

Uh oh!

Uh oh!

Conversation

jakirkham commented Apr 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakirkham commented Apr 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

jakirkham commented Apr 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakirkham commented Apr 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

jakirkham commented Apr 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakirkham commented Apr 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

jakirkham commented Apr 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakirkham commented Apr 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

jakirkham commented Apr 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakirkham commented Apr 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jakirkham commented Apr 20, 2019•
edited
Loading

jakirkham commented Apr 20, 2019•
edited
Loading

jakirkham commented Apr 20, 2019•
edited
Loading

jakirkham commented Apr 20, 2019•
edited
Loading

jakirkham commented Apr 20, 2019•
edited
Loading

jakirkham commented Apr 20, 2019•
edited
Loading

jakirkham commented Apr 20, 2019•
edited
Loading