Uh oh!
There was an error while loading. Please reload this page.
fix: make fixture TOML validation portable - #2
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ORESoftware added a commit
that referenced
this pull request
Jul 30, 2026
Records the branch as merged. It was squash-merged as #1, so its commits were never ancestors of main and it lingered as unmerged. The add/add conflict on scripts/zed-e2e.sh resolves to main content, and not as a side-pick: diffing the two sides shows the branch version is byte-identical to main except that it lacks the python:3.12-bookworm containerization added afterwards in #2. main is therefore a strict superset -- the union of both sides IS main here, and the merged tree is unchanged, so nothing from the branch is dropped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the fixture manifest-consistency check in a pinned Python 3.12 container instead of the host interpreter.
Why
The scripts import
tomllib, which is unavailable in the macOS system Python used for local canary runs. The checks already require Docker, so the pinned container makes the validation reproducible locally and in CI.Validation