Uh oh!
There was an error while loading. Please reload this page.
fix(DEN-1616,DEN-1634): harden Windows zed develop -c - #100
Merged
Conversation
This was referenced Aug 4, 2026
zed develop -czed develop -cORESoftware
marked this pull request as ready for review
August 4, 2026 10:48
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
Problem
Two Windows process-boundary defects were exposed by native clean-room testing:
-NoLogo -Commandand could therefore execute user profile code implicitly.\\?\C:\..., but those identity paths are not accepted consistently as a child-process current directory. A child shell could inherit the nested caller directory whileZED_DEV_PROJECT_ROOTidentified the owning project.Semantic correction
-NoLogo -NoProfile -NonInteractive -Command <script>forpwsh,pwsh.exe,powershell, andpowershell.exe./D /S /C <script>so AutoRun stays disabled.ZED_DEV_PROJECT_ROOT, cache paths, and evidence retain canonical filesystem identity.\\?\C:\pathtoC:\path;\\?\UNC\server\share\pathto\\server\share\path.This preserves both sides of the design: canonical path identity for Zed state and a process-compatible equivalent path for native child launch.
Tests and documentation
docs/powershell-command-mode.md.Validation evidence
The complete repository matrix passed on reviewed head
815edd140e5cceb21983c60ff7e03bb99466567bexcept for one Windows Clippyneedless_returndiagnostic:30887528618— passed;30887528562— passed;30887528774— passed;30887528625— passed;30887528626— passed;30887528656— passed;30887528682— passed;30887528596— passed;30887528970— passed.The only source delta after that matrix is the equivalent tail-expression form in the Windows cwd helper. The exact correction was validated against:
-D warnings.The validation job completed every check successfully; its final push was rejected only because a concurrent evidence commit had already advanced the branch. The checked-in source at final head
3523e577493ce3403ca75f19653f55f6de6ab81ccontains that validated tail expression. Normal protected workflows were then triggered from a connector-authored evidence commit.No credential, registry, cloud service, or production account is used.