Skip to content

feat(DEN-1301): review release plans offline with Playwright - #31

Merged
ORESoftware merged 13 commits into
mainfrom
agent/den-1301-release-plan-html-playwright
Aug 2, 2026
Merged

feat(DEN-1301): review release plans offline with Playwright#31
ORESoftware merged 13 commits into
mainfrom
agent/den-1301-release-plan-html-playwright

Conversation

@ORESoftware

@ORESoftwareORESoftware commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a self-contained browser review artifact for the existing zed release plan --json model and validates it in Chromium with Playwright.

Audit findings addressed

  • release review was limited to terminal prose or raw JSON;
  • there was no rendered escaping contract for manifest-derived package, repository, tag, registry, or directory values;
  • no browser automation proved that release counts, routes, filtering, CSP, accessibility, and responsive behavior match the Rust-generated plan;
  • release reviewers had no portable offline artifact suitable for CI retention.

Changes and hardening

  • adds a dependency-free Node renderer that consumes the authoritative release-plan JSON rather than implementing release planning again;
  • validates the ReleasePlan shape and fails closed on missing fields, malformed fields, unknown options, and missing option values;
  • escapes every dynamic value before inserting it into HTML text or attributes;
  • uses exact SHA-256 CSP hashes, with no remote scripts, styles, fonts, analytics, or requests;
  • publishes through a private same-directory temporary file and atomic rename;
  • refuses an existing symbolic-link output instead of following it;
  • includes exact counts, provenance, explicit empty states, artifact tables, filtering, and Escape-to-clear keyboard behavior;
  • adds deterministic Node tests for schema, escaping, counts, CSP, argument parsing, atomic replacement, and symlink refusal;
  • generates a realistic npm + crates.io plan through the real locked Rust CLI;
  • validates the offline file:// report in Chromium, including filtering, Escape reset, keyboard focus, narrow layout, console/page errors, and external requests;
  • adds a read-only, SHA-pinned GitHub Actions workflow and retains the reviewed report plus failure diagnostics.

Preserved behavior

zed release plan, zed release plan --json, release validation, preflight, and publishing paths are unchanged.

Semantic consolidation

The overlapping draft #32 was reviewed and closed without merge. Its useful unique output-safety and keyboard behaviors were incorporated here. Its branch was reset to main, so no competing renderer or temporary transformation workflow remains.

Final validation

All GitHub Actions workflows passed on exact head d3a436d89587b8ef90cc6dd84defb279031e8c53:

  • release plan browser report;
  • Linux/macOS tests, formatting, doctests, Clippy, shell/help contracts, manifestless consent, Docker boundaries, and Node/Rust lifecycle coverage;
  • repository hardening;
  • develop-shell;
  • polyglot;
  • copy-mode OCI contract;
  • formal review procedure;
  • agents policy.

Linear: DEN-1301

@linear-code

Copy link
Copy Markdown

DEN-1301

@ORESoftware
ORESoftware merged commit 4a65b95 into mainAug 2, 2026
25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ORESoftware