Uh oh!
There was an error while loading. Please reload this page.
fix: make Git-submodule takeover failure-atomic - #98
Closed
ORESoftware wants to merge 16 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #96 merged the requested Git-submodule interoperability surface:
zed install --git-submodules[=true|false];ZED_PKG_GIT_SUBMODULESand matching.cli-flags.tomlmetadata;zed overtake --git-submodulesfor importing committed Zed-package submodules into workspace/dependency authority; and[[git-submodule]]provenance in.zpkg.lock.A post-merge transaction audit found one narrow migration edge:
overtakecommitted the candidate.zpkg.tomlbefore invoking the ordinary installer. A resolution or materialization failure could therefore leave a half-adopted root manifest even though the installer correctly rolled back its own lock and materialized tree.Hardening
Follow-up to #96 and DEN-1612.