fix(orm): enum field filter inside typed JSON compared as raw JSON by ymc9 · Pull Request #2776 · zenstackhq/zenstack

ymc9 · 2026-07-30T00:53:27Z

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

ymc9 · 2026-07-30T00:53:27Z

Fixes#2755

Problem

Filtering by an enum-typed field inside a typed JSON field failed:

db.bKP.findMany({where: {proposal: {bkpType: 'CAPSTONE'}}});

On PostgreSQL this threw invalid input syntax for type json (the JSON-extracted value was compared directly against the bare enum literal), and on SQLite it silently matched nothing (quoted JSON text "CAPSTONE" never equals CAPSTONE).

Fix

In buildTypeJsonNonArrayFilter, the cast-to-text + quote-trim treatment applied to String fields is extended to enum fields, since enum values are stored as JSON strings. The comparison then flows through buildEnumFilter on a plain-text receiver, covering equals, not, in, and notIn.

Testing

New regression test tests/regression/test/issue-2755.test.ts covering direct equality, not, and in filters on both SQLite and PostgreSQL (failed with the issue's exact error before the fix).
Existing e2e suites json-filter.test.ts and typed-json-fields.test.ts pass on both SQLite and PostgreSQL.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved JSON filtering for enum values.
- Fixed equality, negation, and inclusion filters for enums stored inside JSON fields across SQLite and PostgreSQL.

Enum values are stored as JSON strings, but filtering by an enum-typed field of a typed JSON field compared the JSON-extracted value directly against the bare enum literal, failing on Postgres with "invalid input syntax for type json" and silently matching nothing on SQLite. Apply the same cast-to-text + quote-trim treatment used for String fields. Fixes#2755 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

coderabbitai · 2026-07-30T00:54:11Z

📝 Walkthrough

Walkthrough

The ORM now trims surrounding quotes from enum values in typed JSON filters before primitive filter construction. A regression test covers equality, negation, and inclusion queries across SQLite and PostgreSQL.

Changes

Typed JSON enum filtering

Layer / File(s)	Summary
Enum filter value normalization `packages/orm/src/client/crud/dialects/base-dialect.ts`	Typed JSON enum values are quote-trimmed before being passed to `buildPrimitiveFilter`.
Regression coverage for filter operators `tests/regression/test/issue-2755.test.ts`	Tests equality, `not`, and `in` filtering for embedded enum values on SQLite and PostgreSQL.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers:evgenovalov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the enum-filter fix in typed JSON fields.
Linked Issues check	✅ Passed	The code and regression test address `#2755` by making enum filters work inside typed JSON fields.
Out of Scope Changes check	✅ Passed	The changes appear scoped to the reported enum-in-JSON filter bug and its regression coverage.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/issue-2755

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/regression/test/issue-2755.test.ts`:
- Around line 50-54: Add a regression assertion in the bKP.findMany tests for
the filter-builder’s notIn branch, using proposal.bkpType.notIn with
['CAPSTONE'] and asserting that only the record with id '2' is returned.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dcf83742-e96b-4fc8-ba02-97cdbcccd6e4

📥 Commits

Reviewing files that changed from the base of the PR and between b0e2465 and b5e5c26.

📒 Files selected for processing (2)

packages/orm/src/client/crud/dialects/base-dialect.ts
tests/regression/test/issue-2755.test.ts

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

coderabbitaiBot reviewed Jul 30, 2026
View reviewed changes

Comment threadtests/regression/test/issue-2755.test.ts

ymc9 merged commit 19f0820 into devJul 30, 2026
10 checks passed

ymc9 deleted the fix/issue-2755 branch July 30, 2026 09:13

Uh oh!

Uh oh!

Conversation

ymc9 commented Jul 30, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Testing

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jul 30, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

ymc9 commented Jul 30, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Testing

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jul 30, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

ymc9 commented Jul 30, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix

Testing

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jul 30, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

ymc9 commented Jul 30, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 30, 2026•
edited
Loading

ymc9 commented Jul 30, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 30, 2026•
edited
Loading

ymc9 commented Jul 30, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 30, 2026•
edited
Loading

ymc9 commented Jul 30, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 30, 2026•
edited
Loading

ymc9 commented Jul 30, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 30, 2026•
edited
Loading