Uh oh!
There was an error while loading. Please reload this page.
fix: add per-provider native type mapping diagnostics - #2780
Conversation
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe language package identifies ChangesNative type validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/language/src/validators/attribute-application-validator.ts (1)
51-119: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winStrengthen the registry key type to catch provider-name typos at compile time.
Record<string, Set<string>>accepts any string as a key. A misspelled provider literal (for example'postgres'instead of'postgresql') would compile silently and produce a registry entry that never matchesgetDataSourceProvider()'s output, leaving that provider unvalidated without any error.Use a narrower key type so a typo fails to compile.
♻️ Proposed refactor for compile-time provider key safety
-const datasourceProviderSupportedNativeTypes: Record<string, Set<string>> = {+type NativeTypeProvider = 'sqlite' | 'postgresql' | 'mysql';++const datasourceProviderSupportedNativeTypes: Record<NativeTypeProvider, Set<string>> = { sqlite: new Set(),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/language/src/validators/attribute-application-validator.ts` around lines 51 - 119, Strengthen the key type of datasourceProviderSupportedNativeTypes so it only permits the provider names returned by getDataSourceProvider(), rather than arbitrary strings. Reuse the existing provider-name type or derive the key union from the supported provider definitions, while preserving the current sqlite, postgresql, and mysql entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/language/src/validators/attribute-application-validator.ts`:
- Around line 51-119: Strengthen the key type of
datasourceProviderSupportedNativeTypes so it only permits the provider names
returned by getDataSourceProvider(), rather than arbitrary strings. Reuse the
existing provider-name type or derive the key union from the supported provider
definitions, while preserving the current sqlite, postgresql, and mysql entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: caf09d1d-af34-4fa5-9f5c-439570ced830
📒 Files selected for processing (3)
packages/language/src/utils.tspackages/language/src/validators/attribute-application-validator.tspackages/language/test/attribute-application.test.ts
Uh oh!
There was an error while loading. Please reload this page.
Fixes#2759
Summary by CodeRabbit
New Features
Bug Fixes
Tests