Uh oh!
There was an error while loading. Please reload this page.
feat(orm): strict types - #2792
Merged
Merged
Conversation
Contributor
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds ChangesStrict type definition support
Estimated code review effort: 3 (Moderate) | ~30 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/orm/src/client/zod/factory.ts`:
- Around line 465-467: Update the strictness selection in the schema factory
around isStrict to use typeDef.strict === true instead of scanning
typeDef.attributes for @@strict. Preserve the existing z.strictObject and
z.looseObject selection so runtime validation matches the shared TypeDefDef
strictness contract.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6bdf47c3-47d3-460c-8073-cbee101456f1
📒 Files selected for processing (12)
packages/cli/test/ts-schema-gen.test.tspackages/language/res/stdlib.zmodelpackages/language/src/validators/attribute-application-validator.tspackages/language/test/attribute-application.test.tspackages/orm/src/client/crud-types.tspackages/orm/src/client/zod/factory.tspackages/schema/src/schema.tspackages/sdk/src/ts-schema-generator.tstests/e2e/orm/client-api/procedures.test.tstests/e2e/orm/client-api/typed-json-fields.test.tstests/e2e/orm/schemas/procedures/schema.tstests/e2e/orm/schemas/procedures/schema.zmodel
Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/clients/tanstack-query/test/schemas/basic/schema.zmodel`:
- Around line 38-41: Make Profile.bio optional by changing its ZModel
declaration to use the optional string type in
packages/clients/tanstack-query/test/schemas/basic/schema.zmodel:38-41. Then run
zenstack generate to regenerate
packages/clients/tanstack-query/test/schemas/basic/schema-lite.ts:174-188,
ensuring Profile.fields.bio.optional is true.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: ac00b7a9-3be4-49b9-91af-1461a683f680
📒 Files selected for processing (10)
packages/clients/fetch-client/test/fetch-client.test.tspackages/clients/fetch-client/test/schemas/basic/schema-lite.tspackages/clients/fetch-client/test/schemas/basic/schema.zmodelpackages/clients/fetch-client/test/schemas/no-procs/schema.tspackages/clients/fetch-client/test/typing.test-d.tspackages/clients/tanstack-query/test/react/react-typing.test-d.tspackages/clients/tanstack-query/test/schemas/basic/schema-lite.tspackages/clients/tanstack-query/test/schemas/basic/schema.zmodelpackages/clients/tanstack-query/test/svelte/svelte-typing-test.tspackages/clients/tanstack-query/test/vue/vue-typing-test.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for specifying custom type definitions should reject unknown fields via a new
@@strictattribute. This is reflected in both intellisense and runtime input validation.Sample Usage
Why not
@json(strict: true)? A type-level@@strictattribute is simpler to determine strictness, and also works with custom procedures.Summary by CodeRabbit
Summary by CodeRabbit
New Features
@@strictattribute for type definitions.updateProfileoperation to the example API.Bug Fixes
@@stricton models or enums now reports a validation error.