Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/test/db/pull.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -652,6 +652,7 @@ enum Status {
score Float @gte(0.0)
rating Decimal @lt(10)
rank BigInt @lte(999)
extId String @uuid
}`,
);
runCli('db push', workDir);
Expand Down
11 changes: 11 additions & 0 deletions packages/language/res/stdlib.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -542,6 +542,11 @@ attribute @contains(_ text: String, _ message: String?) @@@targetField([StringFi
*/
attribute @regex(_ regex: String, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid UUID.
*/
attribute @uuid(_ version: Int?, _ message: String?) @@@targetField([StringField]) @@@validation

/**
* Validates a string field value is a valid email address.
*/
Expand DownExpand Up@@ -649,6 +654,12 @@ function isDate(field: String): Boolean {
function isTime(field: String, precision: Int?): Boolean {
} @@@expressionContext([ValidationRule])

/**
* Validates a string field value is a valid UUID.
*/
function isUuid(field: String, version: Int?): Boolean {
} @@@expressionContext([ValidationRule])
Comment thread
sanny-io marked this conversation as resolved.

/**
* Validates a string field value is a valid url.
*/
Expand Down
8 changes: 8 additions & 0 deletions packages/language/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,7 @@ import {
isLiteralExpr,
isMemberAccessExpr,
isModel,
isNumberLiteral,
isObjectExpr,
isPlugin,
isReferenceExpr,
Expand DownExpand Up@@ -78,6 +79,13 @@ export function getStringLiteral(node: AstNode | undefined): string | undefined
return isStringLiteral(node) ? node.value : undefined;
}

/**
* Try getting number value from a potential number literal expression
*/
export function getNumberLiteral(node: AstNode | undefined): number | undefined {
return isNumberLiteral(node) ? Number(node.value) : undefined;
}

const isoDateTimeRegex = /^\d{4}(-\d\d(-\d\d(T\d\d:\d\d(:\d\d)?(\.\d+)?(([+-]\d\d:\d\d)|Z)?)?)?)?$/i;

/**
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,6 +29,7 @@ import {
getAttributeArg,
getContainingDataModel,
getDataSourceProvider,
getNumberLiteral,
getStringLiteral,
hasAttribute,
isAuthOrAuthMemberAccess,
Expand DownExpand Up@@ -460,6 +461,14 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
}
}

@check('@uuid')
private _checkUuid(attr: AttributeApplication, accept: ValidationAcceptor) {
const version = getNumberLiteral(attr.args[0]?.value);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', `\`@uuid\` version must be \`4\` or \`7\``, { node: attr.args[0]! });
}
}

@check('@@schema')
private _checkSchema(attr: AttributeApplication, accept: ValidationAcceptor) {
const schemaName = getStringLiteral(attr.args[0]?.value);
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,6 +209,20 @@ export default class FunctionInvocationValidator implements AstValidator<Express
}
}

@func('isUuid')
private _checkIsUuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// second argument must be 4 or 7 if provided
const versionArg = expr.args[1]?.value;
if (versionArg) {
const version = getLiteral<number>(versionArg);
if (version !== undefined && version !== 4 && version !== 7) {
accept('error', 'second argument must be 4 or 7', {
node: expr.args[1]!,
});
}
}
}

@func('cuid')
private _checkCuid(expr: InvocationExpr, accept: ValidationAcceptor) {
// first argument must be 1 or 2 if provided
Expand Down
75 changes: 75 additions & 0 deletions packages/language/test/attribute-application.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -588,6 +588,81 @@ describe('Attribute application validation tests', () => {
});
});

describe('Field-level @uuid attribute', () => {
it('does not require a version arg', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid
}
`,
);
});

it('accepts supported version args', async () => {
await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(4)
}
`,
);

await loadSchema(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(7)
}
`,
);
});

it('rejects unsupported version args', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(1)
}
`,
/`@uuid` version must be `4` or `7`/,
);

await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @uuid(2)
}
`,
/`@uuid` version must be `4` or `7`/,
);
});
});

describe('Native type mapping attributes', () => {
describe('sqlite', () => {
it('rejects when any native type mapping attribute is used', async () => {
Expand Down
48 changes: 48 additions & 0 deletions packages/language/test/function-invocation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -414,4 +414,52 @@ describe('Function Invocation Tests', () => {
);
});
});

describe('isUuid() version validation', () => {
it('should accept valid uuid versions', async () => {
await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(4))

@@validate(isUuid(id, 4))
}
`);

await loadSchema(`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid(7))

@@validate(isUuid(id, 7))
}
`);
});

it('should reject invalid uuid versions', async () => {
await loadSchemaWithError(
`
datasource db {
provider = 'sqlite'
url = 'file:./dev.db'
}

model User {
id String @id @default(uuid())

@@validate(isUuid(id, 1))
}
`,
'second argument must be 4 or 7',
);
});
});
});
18 changes: 18 additions & 0 deletions packages/zod/src/utils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,6 +17,7 @@ const stringFuncZodMap = {
isEmail: 'email',
isUrl: 'url',
isPhone: 'e164',
isUuid: 'uuid',
isDate: 'date',
isTime: 'time',
isDateTime: 'datetime',
Expand DownExpand Up@@ -79,6 +80,15 @@ export function addStringValidation(
}
break;
}
case '@uuid': {
const version = getArgValue<number>(attr.args?.[0]?.value);
if (version === 7) {
result = result.uuidv7();
} else {
result = result.uuidv4();
}
break;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
case '@email':
result = result.email();
break;
Expand DownExpand Up@@ -555,6 +565,7 @@ function evalCall(data: any, expr: CallExpression) {
case 'isEmail':
case 'isUrl':
case 'isPhone':
case 'isUuid':
case 'isDate':
case 'isTime':
case 'isDateTime': {
Expand All@@ -569,6 +580,13 @@ function evalCall(data: any, expr: CallExpression) {
`"isTime" optional second argument must be a number`,
);
return z.iso.time({ precision }).safeParse(fieldArg).success;
} else if (f === 'isUuid') {
const version = getArgValue<number>(expr.args?.[1]);
invariant(
version === null || version == undefined || version === 4 || version === 7,
`"isUuid" optional second argument must 4 or 7`,
);
return z.uuid({ version: version ? `v${version}` : undefined }).safeParse(fieldArg).success;
}
const fn = stringFuncZodMap[f];
return z.string()[fn]().safeParse(fieldArg).success;
Expand Down
13 changes: 13 additions & 0 deletions packages/zod/test/factory.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,6 +27,7 @@ const validUser = {
metadata: null,
status: 'ACTIVE',
address: null,
extId: null,
};

// A fully valid Post object (without relations)
Expand DownExpand Up@@ -285,6 +286,18 @@ describe('SchemaFactory - makeModelSchema', () => {
expect(result.success).toBe(true);
});

it('rejects invalid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: 'not-a-uuid' });
expect(result.success).toBe(false);
});

it('accepts valid uuid for @uuid field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, extId: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' });
expect(result.success).toBe(true);
});

it('rejects invalid date for @date field', () => {
const userSchema = factory.makeModelSchema('User');
const result = userSchema.safeParse({ ...validUser, birthdate: 'not-a-date' });
Expand Down
6 changes: 6 additions & 0 deletions packages/zod/test/schema/schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,6 +83,12 @@ export class SchemaType implements SchemaDef {
optional: true,
attributes: [{ name: "@time" }] as readonly AttributeApplication[]
},
extId: {
name: "extId",
type: "String",
optional: true,
attributes: [{ name: "@uuid" }] as readonly AttributeApplication[]
},
createdAt: {
name: "createdAt",
type: "DateTime",
Expand Down
1 change: 1 addition & 0 deletions packages/zod/test/schema/schema.zmodel
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,6 +34,7 @@ model User {
active Boolean
birthdate String? @date
localTime String? @time
extId String? @uuid
createdAt DateTime?
avatar Bytes?
metadata Json?
Expand Down
7 changes: 7 additions & 0 deletions tests/e2e/orm/validation/custom-validation.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ describe('Custom validation tests', () => {
str6 String?
str7 String?
str8 String?
str9 String?
int1 Int?
list1 Int[]
list2 Int[]
Expand All@@ -41,6 +42,8 @@ describe('Custom validation tests', () => {

@@validate(str8 == null || isTime(str8), 'invalid str8')

@@validate(str9 == null || isUuid(str9), 'invalid str9')

@@validate(list1 == null || (has(list1, 1) && hasSome(list1, [2, 3]) && hasEvery(list1, [4, 5])), 'invalid list1')

@@validate(list2 == null || isEmpty(list2), 'invalid list2', ['x', 'y'])
Expand DownExpand Up@@ -95,6 +98,9 @@ describe('Custom validation tests', () => {
// violates time
await expect(_t({ str8: 'not-a-time' })).toBeRejectedByValidation(['invalid str8']);

// violates uuid
await expect(_t({ str9: 'not-a-uuid' })).toBeRejectedByValidation(['invalid str9']);

// violates has
await expect(_t({ list1: [2, 3, 4, 5] })).toBeRejectedByValidation(['invalid list1']);

Expand DownExpand Up@@ -128,6 +134,7 @@ describe('Custom validation tests', () => {
str6: '+15555555555',
str7: '2000-01-01',
str8: '03:15:00',
str9: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3',
int1: 2,
list1: [1, 2, 4, 5],
list2: [],
Expand Down
14 changes: 14 additions & 0 deletions tests/e2e/orm/validation/toplevel.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,6 +18,8 @@ describe('Toplevel field validation tests', () => {
str8 String? @date
str9 String? @time
str10 String? @time(-1)
str11 String? @uuid
str12 String? @uuid(7)
}
`,
);
Expand DownExpand Up@@ -111,6 +113,18 @@ describe('Toplevel field validation tests', () => {

// satisfies @time(-1)
await expect(_t({ str10: '03:15' })).toResolveTruthy();

// violates @uuid
await expect(_t({ str11: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid
await expect(_t({ str11: '20ef31c8-a2c6-4dca-b87b-838e364ab4b3' })).toResolveTruthy();

// violates @uuid(7)
await expect(_t({ str12: 'not-a-uuid' })).toBeRejectedByValidation(['Invalid UUID']);

// satisfies @uuid(7)
await expect(_t({ str12: '019ff964-2f1d-7668-9a76-8648f2af9146' })).toResolveTruthy();
}
});

Expand Down
Loading