zig mirror download uris do not correctly encode query

[dasimmet]

Since i host a community mirror now, i noticed requests with a path like this:

/zig/zig-x86_64-linux-0.15.2.tar.xz.minisig?source%3Dvscode-zig

but it should be this, right?

/zig/zig-x86_64-linux-0.15.2.tar.xz.minisig?source=vscode-zig

not critical or breaking anything....but my guess is here the query needs to be passed in differently:

vscode-zig/src/versionManager.ts

Line 165 in 81d2533

const artifactMinisignUrlWithQuery = artifactMinisignUrl.with({ query: "source=vscode-zig" });

[Techatrix]

The = has been percent encoded into %3D. This is valid behavior although unnecessary because = is a valid reserved character that doesn't have to be escaped (See RFC 3986). I still think it's better for the extension to avoid percent encoding unless necessary. See #469

The extension also unnecessarily percent encodes the + in the filenames of nightly Zig and ZLS versions. This may cause issues in mirrors that do not properly handle percent encoding. Your mirror does not appear to have this problem:

http://zig-mirror.tsimnet.eu/zig/zig-0.16.0-dev.1254%2Bbf15c791f.tar.xz

[dasimmet]

Thanks for looking into this.
While it is valid in the sense of a valid URL, the percent encoded it is not treated like the key=value it is intended to be:

a = new URL('https://localhost/zig/zig-x86_64-linux-0.16.0-dev.1254%2Bbf15c791f.tar.xz?source%3Dvscode-zig')
a.searchParams
// URLSearchParams { "source=vscode-zig" → "" }

vs

a = new URL('https://localhost/zig/zig-x86_64-linux-0.16.0-dev.1254%2Bbf15c791f.tar.xz?source=vscode-zig')
a.searchParams
// URLSearchParams { source → "vscode-zig" }

[Techatrix]

The URL interface generally is not meant to be passed a percent encoded URI.

It itself already applies percent encoding as you can see here:

a = new URL('https://localhost/zig/zig-x86_64-linux-0.16.0-dev.1254+bf15c791f.tar.xz?source💩vscode-zig')
a.href
// "https://localhost/zig/zig-x86_64-linux-0.16.0-dev.1254+bf15c791f.tar.xz?source%F0%9F%92%A9vscode-zig" 
a.searchParams
// URLSearchParams { "source💩vscode-zig" → "" }
a.search
// "?source%F0%9F%92%A9vscode-zig"

To parse a percent encoded URI into a URL, you would do new URL(decodeURI("")). This unfortunately has its own kind of problems. decodeURI preserves some characters (;/?:@&=+$,#) in their percent encoded form because they are never produced by encodeURI. So this function is incorrect when dealing with arbitrary percent encoded URIs.

I guess this isn't actually an issue in practice because how exactly would you acquire a percent encoded URI that contains something like %3D? I doubt that any of the other Web APIs would produce such output.