Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.2k
Build Runner: Implement File System Watching on Windows #20598
Copy link
Copy link
Closed
Labels
contributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.This issue is limited in scope and/or knowledge of Zig internals.enhancementSolving this issue will likely involve adding new logic or components to the codebase.Solving this issue will likely involve adding new logic or components to the codebase.zig build systemstd.Build, the build runner, `zig build` subcommand, package managementstd.Build, the build runner, `zig build` subcommand, package management
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
contributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.This issue is limited in scope and/or knowledge of Zig internals.enhancementSolving this issue will likely involve adding new logic or components to the codebase.Solving this issue will likely involve adding new logic or components to the codebase.zig build systemstd.Build, the build runner, `zig build` subcommand, package managementstd.Build, the build runner, `zig build` subcommand, package management
Extracted from #20580.
Most of the file system watching mechanism is abstracted across operating systems, however, the parts that deal with receiving events from file system changes require OS-specific implementations.
zig/lib/std/Build/Watch.zig
Line 324 in 1d20ff1
This issue is for the Windows implementation.
Probably the first thing to try will be using the FindFirstChangeNotificationW API. This should fit nicely into the existing abstraction because the Linux implementation is also based on processing events for directories.
WaitForMultipleObjectsis famously limited to only 64 objects. I think that an initial version having this limitation would be fine, but then more advanced techniques will be needed to overcome this limitation, such as https://devblogs.microsoft.com/oldnewthing/20220406-00/?p=106434Related: