make self-hosted the default compiler by andrewrk · Pull Request #12368 · ziglang/zig

andrewrk · 2022-08-08T06:14:01Z

stage1 is available behind the -fstage1 flag.

closes#89

Merge Blockers

General

create an upgrade guide to help smooth the process out for people who want to try the new compiler before the 0.10.0 release.
C ABI tests failing; self-hosted llvm backend is still missing C ABI implementation code #12222
Stage2: Invalid execution of comptime code #12386
~~add valgrind integration to self-hosted~~ I'll do this later

x86_64-freebsd

LavaTech outage
ZIG_EXECUTABLE set to bad value in ci script
stale CI tarball
ld: error: undefined symbol, compiler rt functions
not picking up libc headers, sys/endian.h

aarch64-linux:

stage3 crashing building behavior tests
stage3 crashing building one of the test-compare-output cases

x86_64-linux:

test-cases hanging
run-translated-c remainder test failing

x86_64-macos:

error return traces on the wrong column
stage2 unable to build stage3 on x86_64 macos: panic: incorrect alignment #12387
LLVM module verification failed
crashing when building langref

x86_64-windows:

Windows Azure CI has failures but is still reporting success #12380
TLS miscompilation
stage1 OOM when building stage2
stage2 zig build failing with "error: FileNotFound"
not doing proper mangling of DLL export names

ghost · 2022-08-08T09:15:32Z

YOOOOOOOOOOOOOOOOO

ghost · 2022-08-08T09:24:03Z

Hang on a minute. #89 now says

async/await/suspend/resume will not be available in 0.10.0

So what's the plan there? Do we fall back to stage1 if we see it? Do we just break all code? I feel like I must be out of the loop here.

Vexu · 2022-08-08T09:37:04Z

See #12345

kubkon · 2022-08-08T13:08:22Z

Re failures on macOS, I haven't been able to repro locally on arm64, however, I did notice that for folks linking against a system provided LLVM (e.g., installed via Homebrew, etc.), they will now be forced to manually specify system include and search dirs as well as sysroot path. In order to avoid this silliness, here's my patch suggestion:

diff --git a/src/main.zig b/src/main.zig
index d041036b9..758d27084 100644
--- a/src/main.zig+++ b/src/main.zig@@ -2375,14 +2375,9 @@ fn buildOutputType(
}
}
- if (comptime builtin.target.isDarwin()) {- // If we want to link against frameworks, we need system headers.- if (framework_dirs.items.len > 0 or frameworks.count() > 0)- want_native_include_dirs = true;- }-
if (sysroot == null and cross_target.isNativeOs() and
- (system_libs.count() != 0 or want_native_include_dirs))+ (system_libs.count() != 0 or want_native_include_dirs or+ comptime builtin.target.isDarwin()))
{
const paths = std.zig.system.NativePaths.detect(arena, target_info) catch |err| {
fatal("unable to detect native system paths: {s}", .{@errorName(err)});

In other words, if we are native and targeting Darwin, add system include and search dirs by default, and additionally, try locating the sysroot automatically too.

kubkon · 2022-08-08T13:10:33Z

I did hit this when running a couple of test suites on arm64 macOS:

zig/build on  stage3-default [$!?] via C v13.1.6-clang via △ v3.22.3 via ↯ v0.10.0-dev.3433+cbac7a019 ❯ ./stage3/bin/zig build test-link -Denable-macos-sdk info: PASS build test/link/bss/build.zig (Debug) All 2 tests passed. info: PASS build test/link/common_symbols/build.zig (Debug) All 2 tests passed. info: PASS build test/link/common_symbols/build.zig (ReleaseSafe) All 2 tests passed. info: PASS build test/link/common_symbols/build.zig (ReleaseFast) All 2 tests passed. info: PASS build test/link/common_symbols/build.zig (ReleaseSmall) All 1 tests passed. info: PASS build test/link/common_symbols_alignment/build.zig (Debug) All 1 tests passed. info: PASS build test/link/common_symbols_alignment/build.zig (ReleaseSafe) All 1 tests passed. info: PASS build test/link/common_symbols_alignment/build.zig (ReleaseFast) All 1 tests passed. info: PASS build test/link/common_symbols_alignment/build.zig (ReleaseSmall) Segmentation fault at address 0x70 ???:?:?: 0x1025dcc24 in __ZN4llvm16cast_convert_valIN5clang16EnumConstantDeclEPNS1_4DeclES4_E4doitERKS4_ (???) ???:?:?: 0x10243ac67 in _ZigClangPreprocessingRecord_iterator_deref (???) /Users/kubkon/dev/zig/src/translate_c.zig:452:32: 0x1010f9e7f in prepopulateGlobalNameTable (zig) const entity = it.deref(); ^ /Users/kubkon/dev/zig/src/translate_c.zig:423:35: 0x101107563 in translate (zig) try prepopulateGlobalNameTable(ast_unit, &context); ^ /Users/kubkon/dev/zig/src/Compilation.zig:3446:41: 0x10111fd0f in cImport (zig) var tree = translate_c.translate( ^ /Users/kubkon/dev/zig/src/Sema.zig:4741:42: 0x1017ce66f in zirCImport (zig) const c_import_res = mod.comp.cImport(c_import_buf.items) catch |err| ^ /Users/kubkon/dev/zig/src/Sema.zig:717:65: 0x10166f8af in analyzeBodyInner (zig) .c_import => try sema.zirCImport(block, inst), ^ /Users/kubkon/dev/zig/src/Sema.zig:620:45: 0x10153d1ab in analyzeBodyBreak (zig) const break_inst = sema.analyzeBodyInner(block, body) catch |err| switch (err) { ^ /Users/kubkon/dev/zig/src/Module.zig:4500:50: 0x10153a8bb in semaDecl (zig) const result_ref = (try sema.analyzeBodyBreak(&block_scope, body)).?.operand; ^ /Users/kubkon/dev/zig/src/Module.zig:4141:38: 0x1013c01ab in ensureDeclAnalyzed (zig) const type_changed = mod.semaDecl(decl_index) catch |err| switch (err) { ^ /Users/kubkon/dev/zig/src/Sema.zig:25231:32: 0x1019e3a47 in ensureDeclAnalyzed (zig) sema.mod.ensureDeclAnalyzed(decl_index) catch |err| { ^ /Users/kubkon/dev/zig/src/Sema.zig:25273:32: 0x101846e07 in analyzeDeclRef (zig) try sema.ensureDeclAnalyzed(decl_index); ^ /Users/kubkon/dev/zig/src/Sema.zig:5326:31: 0x1017d19af in zirDeclRef (zig) return sema.analyzeDeclRef(decl_index) catch |err| switch (err) { ^ /Users/kubkon/dev/zig/src/Sema.zig:727:65: 0x10166ff7f in analyzeBodyInner (zig) .decl_ref => try sema.zirDeclRef(block, inst), ^ /Users/kubkon/dev/zig/src/Sema.zig:603:30: 0x10166e66f in analyzeBody (zig) _ = sema.analyzeBodyInner(block, body) catch |err| switch (err) { ^ /Users/kubkon/dev/zig/src/Module.zig:5517:21: 0x10152fc4f in analyzeFnBody (zig) sema.analyzeBody(&inner_block, fn_info.body) catch |err| switch (err) { ^ /Users/kubkon/dev/zig/src/Module.zig:4227:40: 0x1013bf53f in ensureFuncBodyAnalyzed (zig) var air = mod.analyzeFnBody(func, sema_arena) catch |err| switch (err) { ^ /Users/kubkon/dev/zig/src/Compilation.zig:2941:42: 0x1013bdf93 in processOneJob (zig) module.ensureFuncBodyAnalyzed(func) catch |err| switch (err) { /Users/kubkon/dev/zig/src/Compilation.zig:2879:30: 0x1012f8867 in performAllTheWork (zig) try processOneJob(comp, work_item);
^
/Users/kubkon/dev/zig/src/Compilation.zig:2220:31: 0x1012f5f43 in update (zig)
try comp.performAllTheWork(main_progress_node);
^
/Users/kubkon/dev/zig/src/main.zig:3327:20: 0x101317d67 in updateModule (zig)
try comp.update();
^
/Users/kubkon/dev/zig/src/main.zig:3016:17: 0x1011456ab in buildOutputType (zig)
updateModule(gpa, comp, hook) catch |err| switch (err) {
^
/Users/kubkon/dev/zig/src/main.zig:236:31: 0x1010e519b in mainArgs (zig)
return buildOutputType(gpa, arena, args, .zig_test);
^
/Users/kubkon/dev/zig/src/stage1.zig:48:24: 0x1010e49ef in main (zig)
stage2.mainArgs(gpa, arena, args) catch unreachable;
^
???:?:?: 0x10d8f108b in ??? (???)
???:?:?: 0xaf58ffffffffffff in ??? (???)
error: test...
error: The following command terminated unexpectedly:
/Users/kubkon/dev/zig/build/stage3/bin/zig test /Users/kubkon/dev/zig/test/link/interdependent_static_c_libs/main.zig /Users/kubkon/dev/zig/test/link/interdependent_static_c_libs/zig-cache/o/3dca64fe37149040acf5e5f1f76b3493/liba.a
/Users/kubkon/dev/zig/test/link/interdependent_static_c_libs/zig-cache/o/42a1147a229d50846f350c2c0f4d2eb4/libb.a --cache-dir /Users/kubkon/dev/zig/test/link/interdependent_static_c_libs/zig-cache --global-cache-dir /Users/kubkon/
.cache/zig --name test -I /Users/kubkon/dev/zig/test/link/interdependent_static_c_libs --enable-cache error: the following build command failed with exit code 6:
/Users/kubkon/dev/zig/test/link/interdependent_static_c_libs/zig-cache/o/1d2b0f7660520185ebb1ada8ad4c2034/build /Users/kubkon/dev/zig/build/stage3/bin/zig /Users/kubkon/dev/zig/test/link/interdependent_static_c_libs /Users/kubkon/
dev/zig/test/link/interdependent_static_c_libs/zig-cache /Users/kubkon/.cache/zig test

Jarred-Sumner · 2022-08-08T19:10:30Z

Instead of breaking existing projects with the upgrade, could sema detect usage of async (or other unsupported feature) and automatically switch to stage1?

andrewrk · 2022-08-08T20:35:03Z

Instead of breaking existing projects with the upgrade, could sema detect usage of async (or other unsupported feature) and automatically switch to stage1?

I thought about this. I think that the convenience it brings is outweighed by the confusion it might cause, of people not knowing which compiler implementation they are using. I think it should be an intentional choice, and the first question I'm going to ask someone when they report a bug is, "what CLI invocation are you using?" which will tell me which compiler they are using. If it depended on the code, bugs would be harder to diagnose.

Also keep in mind this is transitional period. At some point between now and the next release, this option just disappears entirely.

Also note that for your project you can set stage1 = true in your build script, preventing any users from having to follow any extra directions.

andrewrk · 2022-08-08T20:51:19Z

The aarch64-linux CI failure is #12360

kamidev · 2022-08-09T04:29:55Z

I did hit this when running a couple of test suites on arm64 macOS:
zig/build on  stage3-default [$!?] via C v13.1.6-clang via △ v3.22.3 via ↯ v0.10.0-dev.3433+cbac7a019 

I fail at the same test

➜ build git:(master) ✗ sw_vers;clang --version; zig version
ProductName:	macOS
ProductVersion:	12.5
BuildVersion:	21G72
Homebrew clang version 14.0.6
Target: arm64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /opt/homebrew/opt/llvm/bin
0.10.0-dev.3498+d769fd010

➜ build git:(master) ✗ ./stage3/bin/zig build test-link -Denable-macos-sdk
info: PASS build test/link/bss/build.zig (Debug)
All 2 tests passed.
info: PASS build test/link/common_symbols/build.zig (Debug)
All 2 tests passed.
info: PASS build test/link/common_symbols/build.zig (ReleaseSafe)
All 2 tests passed.
info: PASS build test/link/common_symbols/build.zig (ReleaseFast)
All 2 tests passed.
info: PASS build test/link/common_symbols/build.zig (ReleaseSmall)
All 1 tests passed.
info: PASS build test/link/common_symbols_alignment/build.zig (Debug)
All 1 tests passed.
info: PASS build test/link/common_symbols_alignment/build.zig (ReleaseSafe)
All 1 tests passed.
info: PASS build test/link/common_symbols_alignment/build.zig (ReleaseFast)
All 1 tests passed.
info: PASS build test/link/common_symbols_alignment/build.zig (ReleaseSmall)
thread 2794218 panic: Segmentation fault at address 0x70
Analyzing /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/main.zig: main.zig:c
> %10 = c_import({
%11 = str("b.h")
%12 = as_node(@Zir.Inst.Ref.const_slice_u8_type, %11)
%13 = extended(c_include(%12))
%14 = ensure_result_used(@Zir.Inst.Ref.void_value)
%15 = break_inline(%10, @Zir.Inst.Ref.void_value)
})
%16 = break_inline(%9, %10)
For full context, use the command
zig ast-check -t /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/main.zig
in /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/main.zig: main.zig:test.import C sub
> %21 = decl_ref("c")
???:?:?: 0x106b2cbc8 in __ZN4llvm16cast_convert_valIN5clang16EnumConstantDeclEPNS1_4DeclES4_E4doitERKS4_ (???)
???:?:?: 0x1063caa1f in _ZigClangPreprocessingRecord_iterator_deref (???)
/Users/jonas/src/zig/zig/src/translate_c.zig:452:32: 0x102415aff in prepopulateGlobalNameTable (zig)
const entity = it.deref();
^
/Users/jonas/src/zig/zig/src/translate_c.zig:423:35: 0x1024231e3 in translate (zig)
try prepopulateGlobalNameTable(ast_unit, &context);
^
/Users/jonas/src/zig/zig/src/Compilation.zig:3482:41: 0x102a75173 in cImport (zig)
var tree = translate_c.translate(
^
/Users/jonas/src/zig/zig/src/Sema.zig:4741:42: 0x102895657 in zirCImport (zig)
const c_import_res = mod.comp.cImport(c_import_buf.items) catch |err|
^
/Users/jonas/src/zig/zig/src/Sema.zig:717:65: 0x102740cd3 in analyzeBodyInner (zig)
.c_import => try sema.zirCImport(block, inst),
^
/Users/jonas/src/zig/zig/src/Sema.zig:620:45: 0x1025ffbf3 in analyzeBodyBreak (zig)
const break_inst = sema.analyzeBodyInner(block, body) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Module.zig:4500:50: 0x1025fd303 in semaDecl (zig)
const result_ref = (try sema.analyzeBodyBreak(&block_scope, body)).?.operand;
^
/Users/jonas/src/zig/zig/src/Module.zig:4141:38: 0x102468777 in ensureDeclAnalyzed (zig)
const type_changed = mod.semaDecl(decl_index) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Sema.zig:25233:32: 0x102a9fa2f in ensureDeclAnalyzed (zig)
sema.mod.ensureDeclAnalyzed(decl_index) catch |err| {
^
/Users/jonas/src/zig/zig/src/Sema.zig:25275:32: 0x10290ddf7 in analyzeDeclRef (zig)
try sema.ensureDeclAnalyzed(decl_index);
^
/Users/jonas/src/zig/zig/src/Sema.zig:5326:31: 0x102898997 in zirDeclRef (zig)
return sema.analyzeDeclRef(decl_index) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Sema.zig:727:65: 0x1027413a3 in analyzeBodyInner (zig)
.decl_ref => try sema.zirDeclRef(block, inst),
^
/Users/jonas/src/zig/zig/src/Sema.zig:603:30: 0x10273fa8b in analyzeBody (zig)
_ = sema.analyzeBodyInner(block, body) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Module.zig:5517:21: 0x1025f2697 in analyzeFnBody (zig)
sema.analyzeBody(&inner_block, fn_info.body) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Module.zig:4227:40: 0x102467b0b in ensureFuncBodyAnalyzed (zig)
var air = mod.analyzeFnBody(func, sema_arena) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Compilation.zig:2962:42: 0x10246655f in processOneJob (zig)
module.ensureFuncBodyAnalyzed(func) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/Compilation.zig:2894:30: 0x10239643f in performAllTheWork (zig)
try processOneJob(comp, work_item);
^
/Users/jonas/src/zig/zig/src/Compilation.zig:2234:31: 0x102393a3b in update (zig)
try comp.performAllTheWork(main_progress_node);
^
/Users/jonas/src/zig/zig/src/main.zig:3327:20: 0x1023b593f in updateModule (zig)
try comp.update();
^
/Users/jonas/src/zig/zig/src/main.zig:3016:17: 0x1021e5297 in buildOutputType (zig)
updateModule(gpa, comp, hook) catch |err| switch (err) {
^
/Users/jonas/src/zig/zig/src/main.zig:236:31: 0x1021c2c1f in mainArgs (zig)
return buildOutputType(gpa, arena, args, .zig_test);
^
/Users/jonas/src/zig/zig/src/main.zig:174:20: 0x1021c24f7 in main (zig)
return mainArgs(gpa, arena, args);
^
/Users/jonas/src/zig/zig/build/stage2/lib/zig/std/start.zig:576:37: 0x1021c39c7 in main (zig)
const result = root.main() catch |err| {
^
???:?:?: 0x10e9cd08b in ??? (???)
???:?:?: 0xbf037fffffffffff in ??? (???)
error: test...
error: The following command terminated unexpectedly:
/Users/jonas/src/zig/zig/build/stage3/bin/zig test /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/main.zig /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/zig-cache/o/53b36e50ce70877cd479c2434a2457f3/liba.a /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/zig-cache/o/8bad882ec5f57577e522c8c74924c9ee/libb.a --cache-dir /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/zig-cache --global-cache-dir /Users/jonas/.cache/zig --name test -I /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs --enable-cache
error: the following build command failed with exit code 6:
/Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/zig-cache/o/88be37ed130f9e8fabcccd4a0685ea45/build /Users/jonas/src/zig/zig/build/stage3/bin/zig /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/zig-cache /Users/jonas/.cache/zig test
The following command exited with error code 1 (expected 0):
cd /Users/jonas/src/zig/zig && build/stage3/bin/zig build --build-file /Users/jonas/src/zig/zig/test/link/interdependent_static_c_libs/build.zig test
error: UnexpectedExitCode

This updates to a stage3 freebsd tarball.

For both macOS and FreeBSD.

Instead of a switch in a bash file we just properly name the pipeline steps. Also use zig build to produce the release artifact.

it was returning a pointer to a parameter.

This includes a few recent bug fixes which may solve the Windows CI failure.

Simplify the script by not creating an unnecessary build directory and then changing directories to and from it.

This was present in stage1 but missing from self-hosted.

* accept forward and backward slashes in file paths * strip multiple extensions; e.g. if the basename is "test.exe.obj" then it strips to "test".

empirically this avoids a segfault on the CI.

itsmontoya · 2022-08-20T18:56:50Z

Congratulations @andrewrk ! This is huge!

TheQu1etOwl · 2022-08-21T16:48:14Z

@andrewrk #1481

Some recent change makes slice concatenation runtime (merge #12368), so the example needs to be explicitly made comptime.

stage2 has been merged and set as default around end of aug 2022 in ziglang/zig#12368. since then the main focus has been on this new stage2 compiler. with the release of 0.10.1 the stage2 is fairly useable now and it is the way forward, towards zig 0.11 or 1.0. read more about difference in https://github.com/ziglang/zig/wiki/Self-Hosted-Compiler-Upgrade-Guide another good read on the relevant topic is https://ziglang.org/news/goodbye-cpp/

andrewrk force-pushed the stage3-default branch from bf23aa9 to 0326d61Compare August 8, 2022 06:27

andrewrk force-pushed the stage3-default branch from 0326d61 to bae5cb3Compare August 8, 2022 22:54

andrewrk force-pushed the stage3-default branch from bae5cb3 to 17511a4Compare August 9, 2022 09:59

andrewrk mentioned this pull request Aug 9, 2022
stage2 unable to build stage3 on x86_64 macos: panic: incorrect alignment #12387
Closed

andrewrk force-pushed the stage3-default branch 2 times, most recently from 39cc242 to dc29145Compare August 10, 2022 21:53

kubkon mentioned this pull request Aug 10, 2022
macho: allow unaligned offsets in object files #12398
Merged

andrewrk force-pushed the stage3-default branch 11 times, most recently from d3be887 to 4437f05Compare August 12, 2022 00:24

BratishkaErik mentioned this pull request Aug 15, 2022
sys-fs/ncdu-bin, dev-lang/zig-bin: new packages gentoo/gentoo#26325
Closed

andrewrk force-pushed the stage3-default branch 2 times, most recently from eb31461 to d5d829eCompare August 18, 2022 05:18

andrewrkand others added 20 commits August 19, 2022 16:45

CI: simplify x86 linux test instructions
a73b3a0

langref: update to new error message
09ec9b0

CI: isolate zig-cache for parallel debug/release builds
e3ccea7

CI: avoid concurrent jobs tripping over each other
7346600

build: make docs a separate step than test
d75d40d

CI: windows: build stage3 directly from dev kit
9f43ebd

CI: macos: set release mode for zig and simplify
7cf6930

CI: update freebsd tarball
a8f8629
This updates to a stage3 freebsd tarball.

CI: use zig build to produce release artifact
5b486b1
For both macOS and FreeBSD.

CI: drone: simplify
28e95b3
Instead of a switch in a bash file we just properly name the pipeline steps. Also use zig build to produce the release artifact.

fix std.os.windows.PathSpace.span
445b33c
it was returning a pointer to a parameter.

CI: update windows tarball
5be2e8f
This includes a few recent bug fixes which may solve the Windows CI failure.

build: hook up -Dskip-stage2-tests and remove test-toolchain
c446649

CI: windows: don't create build directory
35f62bc
Simplify the script by not creating an unnecessary build directory and then changing directories to and from it.

LLVM: add DLL export attribute
4373117
This was present in stage1 but missing from self-hosted.

coff: change improperly used packed struct into extern struct
10b95d8

test-stack-traces: relax parsing rules
a85f41e
* accept forward and backward slashes in file paths * strip multiple extensions; e.g. if the basename is "test.exe.obj" then it strips to "test".

std.os.linux.bpf: fix compile error
4a27d2a

CI: update windows tarball
3ce8060

CI: update x86_64-linux tarball
e78e9f3

andrewrk force-pushed the stage3-default branch from 7152a58 to e78e9f3Compare August 19, 2022 23:45

CI: x86_64-linux: avoid cmake ZIG_EXECUTABLE hack
b75eeae
empirically this avoids a segfault on the CI.

andrewrk merged commit e5e6eb9 into masterAug 20, 2022

andrewrk deleted the stage3-default branch August 20, 2022 00:26

malcolmstill mentioned this pull request Aug 20, 2022
Update for zig 0.10 (stage 2) malcolmstill/zware#139
Merged

Kiyoshi364 mentioned this pull request Aug 30, 2022
Using comptime level.asText() in log example #12691
Merged

Vexu pushed a commit that referenced this pull request Aug 31, 2022
Using comptime level.asText() in log example
973b440
Some recent change makes slice concatenation runtime (merge #12368), so the example needs to be explicitly made comptime.

Navigation Menu

Uh oh!

Uh oh!

make self-hosted the default compiler - #12368

make self-hosted the default compiler#12368
andrewrk merged 24 commits into
masterfrom
stage3-default

andrewrk commented Aug 8, 2022•
edited
Loading

Uh oh!

ghost commented Aug 8, 2022

Uh oh!

ghost commented Aug 8, 2022•
edited by ghost
Loading

Uh oh!

Vexu commented Aug 8, 2022

Uh oh!

kubkon commented Aug 8, 2022

Uh oh!

kubkon commented Aug 8, 2022

Uh oh!

Jarred-Sumner commented Aug 8, 2022

Uh oh!

andrewrk commented Aug 8, 2022•
edited
Loading

Uh oh!

andrewrk commented Aug 8, 2022

Uh oh!

kamidev commented Aug 9, 2022

Uh oh!

itsmontoya commented Aug 20, 2022

Uh oh!

TheQu1etOwl commented Aug 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

andrewrk commented Aug 8, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Blockers

General

x86_64-freebsd

aarch64-linux:

x86_64-linux:

x86_64-macos:

x86_64-windows:

Uh oh!

ghost commented Aug 8, 2022

Uh oh!

ghost commented Aug 8, 2022• edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vexu commented Aug 8, 2022

Uh oh!

kubkon commented Aug 8, 2022

Uh oh!

kubkon commented Aug 8, 2022

Uh oh!

Jarred-Sumner commented Aug 8, 2022

Uh oh!

andrewrk commented Aug 8, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewrk commented Aug 8, 2022

Uh oh!

kamidev commented Aug 9, 2022

Uh oh!

itsmontoya commented Aug 20, 2022

Uh oh!

TheQu1etOwl commented Aug 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

andrewrk commented Aug 8, 2022•
edited
Loading

ghost commented Aug 8, 2022•
edited by ghost
Loading

andrewrk commented Aug 8, 2022•
edited
Loading