Skip to content

give BSDs some attention - #13699

Merged
andrewrk merged 15 commits into
ziglang:masterfrom
mikdusan:bsd
Jan 3, 2023
Merged

give BSDs some attention#13699
andrewrk merged 15 commits into
ziglang:masterfrom
mikdusan:bsd

Conversation

@mikdusan

@mikdusanmikdusan commented Nov 29, 2022•
edited
Loading

Copy link
Copy Markdown
Member
  • make general progress on tier-2 BSDs
  • there may be some minor patches for macOS and others included

closes#13700

please see status/details in #13700

@mikdusanmikdusan added os-freebsd FreeBSD os-netbsd NetBSD os-openbsd OpenBSD os-dragonfly DragonFly BSD labels Nov 29, 2022
@mikdusanmikdusan mentioned this pull request Nov 29, 2022
Closed
@mikdusan
mikdusanforce-pushed the bsd branch 2 times, most recently from 4ab7715 to 76edf77CompareNovember 29, 2022 23:48
@andrewrk
andrewrk self-requested a review November 30, 2022 00:51
@semarie

semarie commented Dec 3, 2022

Copy link
Copy Markdown
Contributor

FYI, openbsd build work well with the diff, and tests are still passing.

@mikdusan
mikdusanforce-pushed the bsd branch 3 times, most recently from 6b84514 to 3f167f5CompareDecember 8, 2022 12:45
@squeek502squeek502 mentioned this pull request Dec 9, 2022
Merged
@mikdusanmikdusan mentioned this pull request Dec 15, 2022
Closed
@theoparis

theoparis commented Dec 27, 2022•
edited
Loading

Copy link
Copy Markdown

Is it just me or does building this PR cause an entire 64 gb of swap to be used when compiling stage3 (build-host-zig) with zig-bootstrap 🤔

I tried to use zig bootstrap but I replaced the zig folder with your bsd branch and it seems to be causing this massive memory leak.

daurnimator
daurnimator reviewed Dec 27, 2022
View reviewed changes
Comment threadlib/std/os.zig Outdated
Comment threadlib/std/os.zig Outdated
@mikdusan

mikdusan commented Dec 28, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Is it just me or does building this PR cause an entire 64 gb of swap to be used when compiling stage3 (build-host-zig) with zig-bootstrap 🤔

It's not just you! Trying to narrow down what is causing this. Strange tho, I am able to manually use the ld.lld args with BOTH zig ld.lld and even my dep llvm toolchain's ld.lld and linking succeeds without eating up huge GB's.

update: I threw out the mission-creep of linking to system c++ via regular -l options and thus the massive memory grab doesn't manifest anymore

@mikdusan
mikdusanforce-pushed the bsd branch 2 times, most recently from 17430f0 to 1277900CompareDecember 30, 2022 21:44
@mikdusan
mikdusan marked this pull request as ready for review December 30, 2022 21:44
@semarie

semarie commented Dec 31, 2022

Copy link
Copy Markdown
Contributor

@mikdusan do you think that PR could be splitted and commits incrementally done (instead of pushing all in one big PR) ?

currently, several OS are broken waiting for only some commits in this PR (like "avoid Dir.realpathAlloc").

having a good BSD support is a very good target (and thanks for your work on it), but I would be glad to have a working compiler too.

@mikdusan

mikdusan commented Dec 31, 2022

Copy link
Copy Markdown
MemberAuthor

@mikdusan do you think that PR could be splitted and commits incrementally done (instead of pushing all in one big PR) ?

I'd like to get a review from andrew first. But yeah if it makes some pieces land faster, I'm open to splitting things up.

andrewrk
andrewrk requested changes Jan 2, 2023
View reviewed changes

@andrewrkandrewrk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for giving some attention to the BSDs. In particular you have made me realize that a problematic commit has been residing in master branch for quite some time, which I have reverted.

I left a few review comments, but with those resolved, this changeset looks ready to merge to me.

Comment threadsrc/main.zig Outdated
Comment threadCMakeLists.txt Outdated
Comment threadlib/libcxx/include/__config
Comment threadsrc/Compilation.zig Outdated
@mikdusan
link.Elf: resolve CsuObjects TODO
d78a261
@mikdusan
cmake: ignore case for TARGET ARCH/OS mapping
0cb8ed6
- first convert to lower-case then perform mappings
- effect: freebsd, netbsd and openbsd convert arch `amd64` to `x86_64`
- effect: convert `arm64` to `aarch64`
@mikdusan
std.fs: add NAME_MAX for openbsd and netbsd
e872c72
@mikdusan
macos: getFdPath: handle E.NOSPC
4cdbde5
- per darwin-xnu source, fcntl F_GETPATH will return ENOSPC when path
exceeds either user-supplied buffer or system MAXPATHLEN
- macOS does not document this (and other) possible errno values
@mikdusan
freebsd: getFdPath: < 13.1 fallback impl
5376247
@mikdusan
freebsd: getFdPath: handle NameTooLong
bd071c9
@mikdusan
freebsd: memfd_create: < 13.0 version check
7f012ee
- add conditional compile error
- add conditional skip test
@mikdusan
dragonfly: getFdPath: F_GETPATH implementation
7da9348
@mikdusan
dragonfly: port libc++
1a40338
- https://github.com/DragonFlyBSD/DPorts/tree/master/devel/libc++/files
for hints as to which patches are needed
@mikdusan
netbsd: getFdPath: F_GETPATH implementation
e752606
@mikdusan
std.Target: bump semver max for BSDs
46c3b09
- freebsd, netbsd, openbsd, dragonfly
@mikdusan
build stage3: add more BSD support
ef08894
- add netbsd
- add dragonfly
- fixup freebsd
@mikdusan
dragonfly: add std.c.arc4random_buf
69553d6
This allows for a more optimal std.crypto.tlcsprng codepath.
Without it a an "incorrect alignment" panic is triggered from
crypto.tlcsprng which aligns a threadlocal but it's actually
not aligned, thus detected by the safety check.
It appears that LLVM-IR does attribute the storage with alignment
but it is ultimately not respected in the final binary for netbsd
and dragonfly.
@mikdusan
freebsd: add std.c.arc4random_buf
571b817
@mikdusan
dragonfly: pass test: lib/std/std.zig
7798af7
@andrewrk
andrewrk merged commit 8bd734d into ziglang:masterJan 3, 2023
@andrewrk

andrewrk commented Jan 3, 2023

Copy link
Copy Markdown
Member

Great work, thank you very much!

@mikdusan
mikdusan deleted the bsd branch January 5, 2023 22:33
andrewrk added a commit that referenced this pull request Jan 9, 2023
@andrewrk
Merge pull request#13699from mikdusan/bsd
be6a81d
give BSDs some attention
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewrkandrewrkandrewrk requested changes
+1 more reviewer
@daurnimatordaurnimatordaurnimator left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

os-dragonflyDragonFly BSDos-freebsdFreeBSDos-netbsdNetBSDos-openbsdOpenBSD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

give BSDs some attention

5 participants

@mikdusan@semarie@theoparis@andrewrk@daurnimator