Uh oh!
There was an error while loading. Please reload this page.
zig build: run steps in parallel - #14647
Merged
Merged
Conversation
andrewrkforce-pushed
the
build-parallel
branch
from
February 16, 2023 22:27
b723cb0 to
1fc5517Compareandrewrkforce-pushed
the
build-parallel
branch
2 times, most recently
from
February 21, 2023 17:32
0589977 to
f9ceb2bCompareandrewrkforce-pushed
the
build-parallel
branch
7 times, most recently
from
March 7, 2023 07:51
07a4545 to
6c14064Compare
This was referenced Mar 7, 2023
This was referenced Mar 8, 2023
andrewrkforce-pushed
the
build-parallel
branch
3 times, most recently
from
March 10, 2023 05:21
4deabd3 to
0360628Compareandrewrkforce-pushed
the
build-parallel
branch
2 times, most recently
from
March 12, 2023 07:43
4d83076 to
1b8da32Compare
This was referenced Mar 17, 2023
sterchelen added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 17, 2023
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars.
sterchelen added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 17, 2023
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars. Signed-off-by: Nicolas Sterchele <nicolas@sterchelen.net>
sterchelen added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0
sterchelen added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0 Also, MakeFn now takes a std.Progress.Node introduces by ziglang/zig@0e07879
sterchelen added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
As part of ziglang/zig#14647 and more specifically this zig commit ziglang/zig@bf73620, the color is now communicated via env vars. Signed-off-by: Nicolas Sterchele <nicolas@sterchelen.net>
sterchelen added a commit
to sterchelen/ziglings
that referenced
this pull request
Mar 18, 2023
Step's Options introduced from the following PR ziglang/zig#14647 and more precisely this commit ziglang/zig@02381c0 Also, MakeFn now takes a std.Progress.Node introduces by ziglang/zig@0e07879
This was referenced Mar 19, 2023
sterchelen added a commit
to sterchelen/zig
that referenced
this pull request
Mar 20, 2023
Follow-up actions from ziglang#14647Fixesziglang#14947
sterchelen added a commit
to sterchelen/zig
that referenced
this pull request
Mar 20, 2023
Follow-up actions from ziglang#14647Fixesziglang#14947
sterchelen added a commit
to sterchelen/zig
that referenced
this pull request
Apr 28, 2023
Follow-up actions from ziglang#14647Fixesziglang#14947
sterchelen added a commit
to sterchelen/zig
that referenced
this pull request
May 2, 2023
Follow-up actions from ziglang#14647Fixesziglang#14947
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally, after this PR, when you run
zig build, it will actually use all your cores to do stuff in parallel.After fixing any issues that crop up in zig's own build script, this should reduce the CI time, as well as make it more palatable to use
zig buildfor local testing. For example,zig build test-translate-cin this branch took 0.8s for me vs 12s for master.Follow-Up Issues:
process.exit(1)inmake()implementations, instead set the stderr of step result. this way we don't end up with dead, useless threads.