Uh oh!
There was an error while loading. Please reload this page.
Build.zig rename orgy. Renames FileSource to LazyPath and others - #16446
Merged
Conversation
andrewrk
commented
Jul 24, 2023
Member
ikskuhforce-pushed
the
buildsystem_rename_orgy
branch
7 times, most recently
from
July 27, 2023 00:27
a21f99d to
643ec8cCompareikskuh
marked this pull request as ready for review
July 27, 2023 16:42
andrewrkforce-pushed
the
buildsystem_rename_orgy
branch
from
July 30, 2023 07:12
afea80d to
810f3f5Compareandrewrk
commented
Jul 30, 2023
Member
I pushed a big-ass commit to this branch. This will be ready to merge after I do some more testing on some other projects that exercise the build system. |
…yPath and removes functions that take literal paths instead of LazyPath.
* introduce LazyPath.cwd_relative variant and use it for --zig-lib-dir. closesziglang#12685 * move overrideZigLibDir and setMainPkgPath to options fields set once and then never mutated. * avoid introducing Build/util.zig * use doc comments for deprecation notices so that they show up in generated documentation. * introduce InstallArtifact.Options, accept it as a parameter to addInstallArtifact, and move override_dest_dir into it. Instead of configuring the installation via Compile step, configure the installation via the InstallArtifact step. In retrospect this is obvious. * remove calls to pushInstalledFile in InstallArtifact. See ziglang#14943 * rewrite InstallArtifact to not incorrectly observe whether a Compile step has any generated outputs. InstallArtifact is meant to trigger output generation. * fix child process evaluation code handling of `-fno-emit-bin`. * don't store out_h_filename, out_ll_filename, etc., pointlessly. these are all just simple extensions appended to the root name. * make emit_directory optional. It's possible to have nothing outputted, for example, if you're just type-checking. * avoid passing -femit-foo/-fno-emit-foo when it is the default * rename ConfigHeader.getTemplate to getOutput * deprecate addOptionArtifact * update the random number seed of Options step caching. * avoid using `inline for` pointlessly * avoid using `override_Dest_dir` pointlessly * avoid emitting an executable pointlessly in test cases Removes forceBuild and forceEmit. Let's consider these additions separately. Nearly all of the usage sites were suspicious.
andrewrkforce-pushed
the
buildsystem_rename_orgy
branch
from
July 30, 2023 18:19
810f3f5 to
6393928CompareThis branch was not intended to introduce new test coverage on the emit-h feature. See ziglang#9698
The callsites of getPath rely on the result being absolute so that they can pass the path to a child process with the cwd set to the build root.
andrewrk
enabled auto-merge
July 31, 2023 03:32
raysan5 pushed a commit
to raysan5/raylib
that referenced
this pull request
Aug 1, 2023
joachimschmidt557 pushed a commit
to joachimschmidt557/linenoize
that referenced
this pull request
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tries to resolve#16353 and #16351