Uh oh!
There was an error while loading. Please reload this page.
std.windows: use atomic rename, if possible - #16717
Conversation
squeek502
commented
Aug 7, 2023
This should use the same strategy as #16499, since the same caveat (presumably) applies for non-NTFS filesystems. |
Uh oh!
There was an error while loading. Please reload this page.
matu3ba
commented
Aug 19, 2023
CI passes now. Do you think further tests are needed @squeek502 ? |
squeek502
commented
Aug 19, 2023
Would be good to test to confirm that this will actually mitigate #14978 (see the reproduction in #14978 (comment)) |
squeek502
commented
Aug 20, 2023
I can confirm that the fallback works--the fs tests pass when running on a FAT32 drive (and I confirmed that |
Uh oh!
There was an error while loading. Please reload this page.
I can also confirm that this successfully avoids (there is a second process of the same Once #16717 (comment) is addressed, I think this will be good to go. |
Uh oh!
There was an error while loading. Please reload this page.
Also add optimization for happy path with early return. No idea, why this worked before.
Most of these tests were made to pass by ziglang#16717, but there were a few loose ends to tie up with regards to the 'fallback' behavior (when FILE_RENAME_POSIX_SEMANTICS either isn't available or isn't supported by the underlying filesystem). We now do a bit of extra work to get POSIX-like renaming in the fallback path. Closesziglang#6364
Mitigates #14978.